Go 1.24 complains about non-constant format strings

Author: migue

internal/integration/parse.go

@@ -164,6 +164,11 @@ func readPktline(r io.Reader) ([]byte, error) {
 
 func writePktlinef(w io.Writer, format string, args ...interface{}) error {
 	msg := fmt.Sprintf(format, args...)
+	err := writePktline(w, msg)
+	return err
+}
+
+func writePktline(w io.Writer, msg string) error {
 	_, err := fmt.Fprintf(w, "%04x%s", 4+len(msg), msg)
 	return err
 }

internal/integration/pushoptions_test.go

@@ -126,8 +126,8 @@ func TestPushOptionsLimitCount(t *testing.T) {
 
 	// the limit is 2, let's send 3 push options
 	for i := 0; i < 3; i++ {
-		require.NoError(t, writePktlinef(srpIn,
-			fmt.Sprintf("option-%d\n", i)))
+		option := fmt.Sprintf("option-%d\n", i)
+		require.NoError(t, writePktline(srpIn, option))
 	}
 	_, err = srpIn.Write([]byte("0000"))
 	require.NoError(t, err)