Skip to content

Commit 918362f

Browse files
authored
Merge pull request #2950 from github/koesie10/variant-analysis-save-before-start
Use `saveBeforeStart` setting when running a variant analysis
2 parents 3a03570 + 1121852 commit 918362f

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

extensions/ql-vscode/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
- Fix a bug where the query server was restarted twice after configuration changes. [#2884](https://github.com/github/vscode-codeql/pull/2884).
99
- Add support for the `telemetry.telemetryLevel` setting. For more information, see the [telemetry documentation](https://codeql.github.com/docs/codeql-for-visual-studio-code/about-telemetry-in-codeql-for-visual-studio-code). [#2824](https://github.com/github/vscode-codeql/pull/2824).
1010
- Fix syntax highlighting directly after import statements with instantiation arguments. [#2792](https://github.com/github/vscode-codeql/pull/2792)
11+
- The `debug.saveBeforeStart` setting is now respected when running variant analyses. [#2950](https://github.com/github/vscode-codeql/pull/2950)
1112

1213
## 1.9.1 - 29 September 2023
1314

extensions/ql-vscode/src/variant-analysis/variant-analysis-manager.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ import {
4242
processVariantAnalysisRepositoryTask,
4343
} from "./variant-analysis-processor";
4444
import PQueue from "p-queue";
45-
import { createTimestampFile } from "../run-queries-shared";
45+
import { createTimestampFile, saveBeforeStart } from "../run-queries-shared";
4646
import { readFile, remove, pathExists } from "fs-extra";
4747
import { EOL } from "os";
4848
import { cancelVariantAnalysis } from "./gh-api/gh-actions-api-client";
@@ -199,6 +199,8 @@ export class VariantAnalysisManager
199199
progress: ProgressCallback,
200200
token: CancellationToken,
201201
): Promise<void> {
202+
await saveBeforeStart();
203+
202204
progress({
203205
maxStep: 5,
204206
step: 0,

0 commit comments

Comments
 (0)