Skip to content

Commit eb95b78

Browse files
committed
Mark authenticatorAttachment as nullable.
1 parent 120cbb1 commit eb95b78

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/webauthn-json/basic/json.ts

+3-4
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ interface AuthenticationExtensionsClientOutputsJSON
1515

1616
export interface PublicKeyCredentialWithClientExtensionResults
1717
extends PublicKeyCredential {
18-
// TODO: This field is technically not optional in the spec, but Firefox hasn't implemented it.
19-
authenticatorAttachment?: string;
18+
authenticatorAttachment?: string | null;
2019
clientExtensionResults?: AuthenticationExtensionsClientOutputsJSON;
2120
}
2221

@@ -45,7 +44,7 @@ interface PublicKeyCredentialJSON {
4544
type: PublicKeyCredentialType;
4645
rawId: Base64urlString;
4746
// TODO: This field is technically not optional in the spec, but Firefox hasn't implemented it.
48-
authenticatorAttachment?: AuthenticatorAttachment;
47+
authenticatorAttachment?: AuthenticatorAttachment | null;
4948
}
5049

5150
// `navigator.create()` request
@@ -88,7 +87,7 @@ export interface AuthenticatorAttestationResponseJSON {
8887
attestationObject: Base64urlString;
8988
transports: string[];
9089
// This field is technically not optional in the spec, but Firefox hasn't implemented it.
91-
authenticatorAttachment?: AuthenticatorAttachment;
90+
authenticatorAttachment?: AuthenticatorAttachment | null;
9291
}
9392

9493
export interface PublicKeyCredentialWithAttestationJSON

0 commit comments

Comments
 (0)