-
Notifications
You must be signed in to change notification settings - Fork 34
Open
0 / 40 of 4 issues completedOpen
0 / 40 of 4 issues completed
Copy link
Labels
Description
Overview
This tracking issue addresses the schema documentation issue discovered in Discussion #7174 where the expires field pattern advertises hour support but the implementation doesn't provide it.
Source: Discussion #7174
Problem
The schema pattern ^[0-9]+[hHdDwWmMyY]$ includes h and H for hours, but the parseRelativeTimeSpec() function in pkg/workflow/config_helpers.go only handles d, w, m, y.
Impact:
- User writes
expires: "20h"→ Passes schema validation ✓ - Runtime processes it → Rejects with "Invalid expires time spec unit" ✗
- Function returns 0 → Expires field effectively disabled
- Inconsistent UX: schema says valid but fails at runtime
Affected Components
- Schema:
pkg/parser/schemas/main_workflow_schema.json - Code:
pkg/workflow/config_helpers.go - All safe-outputs configurations (issues, discussions, comments, etc.)
Planned Tasks
- Update schema pattern to remove hour support
- Rebuild binary with updated schema
- Add test coverage for expires field validation
- Update documentation if needed
Decision
Following the discussion recommendation, we'll update the schema pattern (simpler than adding hours support) since the expires feature is for managing long-lived issues/discussions where hour-level granularity isn't necessary.
AI generated by Plan Command for discussion #7174