Skip to content

Commit d222a2d

Browse files
authored
Merge pull request #4 from gitkraken/fix-windows-file-blacklist
fix windows-blacklist
2 parents 308cbb4 + c8470bb commit d222a2d

File tree

6 files changed

+64
-18
lines changed

6 files changed

+64
-18
lines changed

.github/workflows/ci.yml

+2
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ jobs:
5252
exclude:
5353
- os: macos-11
5454
arch: x86
55+
- os: windows-2019
56+
arch: x86
5557
timeout-minutes: 20
5658
steps:
5759
# We need to use Xcode 11.7 for maximum compatibility with older macOS (x64)

dependencies.json

-7
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,6 @@
88
"filename": "PortableGit-2.44.0-64-bit.7z.exe",
99
"url": "https://github.com/git-for-windows/git/releases/download/v2.44.0.windows.1/PortableGit-2.44.0-64-bit.7z.exe",
1010
"checksum": "1fc64ca91b9b475ab0ada72c9f7b3addbe69a6c8f520be31425cf21841cca369"
11-
},
12-
{
13-
"platform": "windows",
14-
"arch": "x86",
15-
"filename": "PortableGit-2.44.0-32-bit.7z.exe",
16-
"url": "https://github.com/git-for-windows/git/releases/download/v2.44.0.windows.1/PortableGit-2.44.0-32-bit.7z.exe",
17-
"checksum": "e70c80672069907961f6db68b0db5e14ea0447f39c74cfd3c385882f3b934c6f"
1811
}
1912
]
2013
},

script/build-win32.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ if [ "$TARGET_ARCH" = "x64" ]; then
1414
DEPENDENCY_ARCH="amd64"
1515
MINGW_DIR="mingw64"
1616
else
17-
DEPENDENCY_ARCH="x86"
18-
MINGW_DIR="mingw32"
17+
echo "Unsupported architecture"
18+
exit 1
1919
fi
2020

2121
GIT_LFS_VERSION=$(jq --raw-output ".[\"git-lfs\"].version[1:]" dependencies.json)
@@ -45,7 +45,7 @@ fi
4545

4646
echo "-- Deleting Unneccessary Files"
4747
cd "$DESTINATION"
48-
xargs rm -rf <"$CURRENT_DIR/windows-blacklist.txt"
48+
tr -d '\r' < "$CURRENT_DIR/windows-blacklist.txt" | xargs -d '\n' rm -rf
4949

5050
if [[ "$GIT_LFS_VERSION" ]]; then
5151
# download Git LFS, verify its the right contents, and unpack it

script/generate-release-notes.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import * as fs from 'fs'
44
import { Octokit } from '@octokit/rest'
55

66
export default class GenerateReleaseNotes {
7-
// eight targeted OS/arch combinations
7+
// seven targeted OS/arch combinations
88
// two files for each targeted OS/arch
99
// two checksum files for the previous
10-
private SUCCESSFUL_RELEASE_FILE_COUNT = 8 * 2 * 2
10+
private SUCCESSFUL_RELEASE_FILE_COUNT = 7 * 2 * 2
1111
private args = process.argv.slice(2)
1212
private expectedArgs = [
1313
{

script/update-git.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,12 @@ async function run() {
204204
}
205205

206206
const package64bit = await getPackageDetails(assets, body, 'amd64')
207-
const package32bit = await getPackageDetails(assets, body, 'x86')
208207

209-
if (package64bit == null || package32bit == null) {
208+
if (package64bit == null) {
210209
return
211210
}
212211

213-
updateGitDependencies(latestGitVersion, [package64bit, package32bit])
212+
updateGitDependencies(latestGitVersion, [package64bit])
214213

215214
console.log(
216215
`✅ Updated dependencies metadata to Git ${latestGitVersion} (Git for Windows ${version})`

script/windows-blacklist.txt

+55-3
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,13 @@ cmd/start-ssh-agent.cmd
55
cmd/start-ssh-pageant.cmd
66
dev
77
etc/package-versions.txt
8+
etc/profile.d/perlbin.csh
9+
etc/profile.d/perlbin.sh
10+
etc/vimrc
811
git-bash.exe
912
git-cmd.exe
1013
mingw64/libexec/git-core/Atlassian.Bitbucket.dll
14+
mingw64/libexec/git-core/av_libglesv2.dll
1115
mingw64/libexec/git-core/Avalonia.Base.dll
1216
mingw64/libexec/git-core/Avalonia.Controls.dll
1317
mingw64/libexec/git-core/Avalonia.DesignerSupport.dll
@@ -22,14 +26,22 @@ mingw64/libexec/git-core/Avalonia.Remote.Protocol.dll
2226
mingw64/libexec/git-core/Avalonia.Skia.dll
2327
mingw64/libexec/git-core/Avalonia.Themes.Fluent.dll
2428
mingw64/libexec/git-core/Avalonia.Win32.dll
25-
mingw64/libexec/git-core/av_libglesv2.dll
2629
mingw64/libexec/git-core/edit.dll
2730
mingw64/libexec/git-core/gcmcore.dll
31+
mingw64/libexec/git-core/git-citool
32+
mingw64/libexec/git-core/git-credential-wincred.exe
33+
mingw64/libexec/git-core/git-credential-wincred.exe
34+
mingw64/libexec/git-core/git-daemon.exe
2835
mingw64/libexec/git-core/git-gui
2936
mingw64/libexec/git-core/git-gui--askpass
3037
mingw64/libexec/git-core/git-gui--askyesno
31-
mingw64/libexec/git-core/git-credential-wincred.exe
3238
mingw64/libexec/git-core/git-gui.tcl
39+
mingw64/libexec/git-core/git-imap-send.exe
40+
mingw64/libexec/git-core/git-instaweb
41+
mingw64/libexec/git-core/git-p4
42+
mingw64/libexec/git-core/git-send-email
43+
mingw64/libexec/git-core/git-svn
44+
mingw64/libexec/git-core/git-svn
3345
mingw64/libexec/git-core/GitHub.dll
3446
mingw64/libexec/git-core/GitLab.dll
3547
mingw64/libexec/git-core/HarfBuzzSharp.dll
@@ -92,6 +104,46 @@ mingw64/libexec/git-core/System.ValueTuple.dll
92104
mingw64/libexec/git-core/tcl86.dll
93105
mingw64/libexec/git-core/tk86.dll
94106
mingw64/libexec/git-core/zlib1.dll
107+
mingw64/share/doc
108+
mingw64/share/perl5
95109
post-install.bat
96110
README.portable
97-
tmp
111+
tmp
112+
usr/bin/core_perl
113+
usr/bin/mintty.exe
114+
usr/bin/msys-perl5_38.dll
115+
usr/bin/msys-svn_client-1-0.dll
116+
usr/bin/msys-svn_delta-1-0.dll
117+
usr/bin/msys-svn_diff-1-0.dll
118+
usr/bin/msys-svn_fs_fs-1-0.dll
119+
usr/bin/msys-svn_fs_util-1-0.dll
120+
usr/bin/msys-svn_fs_x-1-0.dll
121+
usr/bin/msys-svn_fs-1-0.dll
122+
usr/bin/msys-svn_ra_local-1-0.dll
123+
usr/bin/msys-svn_ra_serf-1-0.dll
124+
usr/bin/msys-svn_ra_svn-1-0.dll
125+
usr/bin/msys-svn_ra-1-0.dll
126+
usr/bin/msys-svn_repos-1-0.dll
127+
usr/bin/msys-svn_subr-1-0.dll
128+
usr/bin/msys-svn_swig_perl-1-0.dll
129+
usr/bin/msys-svn_swig_perl-1-0.dll
130+
usr/bin/msys-svn_wc-1-0.dll
131+
usr/bin/notepad
132+
usr/bin/perl.exe
133+
usr/bin/perl5.38.2.exe
134+
usr/bin/rvim
135+
usr/bin/sshd
136+
usr/bin/vendor_perl
137+
usr/bin/vi
138+
usr/bin/view
139+
usr/bin/vim.exe
140+
usr/bin/vimdiff.exe
141+
usr/bin/vimtutor
142+
usr/bin/wordpad
143+
usr/lib/perl5
144+
usr/share/licenses/perl-Net-SSLeay
145+
usr/share/licenses/perl-TermReadKey
146+
usr/share/licenses/perl-Try-Tiny
147+
usr/share/nano/perl.nanorc
148+
usr/share/perl5
149+
usr/share/vim

0 commit comments

Comments
 (0)