Fixes #4833 improves gate button text color across themes

Author: d13

src/webviews/apps/shared/components/button.ts

@@ -140,12 +140,16 @@ export class GlButton extends LitElement {
 			:host([appearance='alert']) {
 				--button-background: transparent;
 				--button-border: var(--color-alert-infoBorder);
-				--button-foreground: var(--color-button-foreground);
+				--button-foreground: var(--color-alert-infoForeground);
 				--button-hover-background: var(--color-alert-infoBorder);
 				--button-line-height: 1.64;
 				width: max-content;
 			}
 
+			:host([appearance='alert']:hover) {
+				--button-foreground: var(--vscode-button-foreground);
+			}
+
 			/* Variant property for semantic states - appearance controls structure, variant controls color */
 
 			/* Solid buttons (default and secondary) with variants get full color treatment */
@@ -213,11 +217,6 @@ export class GlButton extends LitElement {
 				--button-border: transparent;
 			}
 
-			:host-context(.vscode-light):host([appearance='alert']:not(:hover)),
-			:host-context(.vscode-high-contrast-light):host([appearance='alert']:not(:hover)) {
-				--button-foreground: var(--color-foreground);
-			}
-
 			:host([appearance='input']) .control {
 				padding: var(--button-input-padding);
 				--button-line-height: 1.1;