Skip to content

Commit 7b6959d

Browse files
nandajavarmaroboquat
authored andcommitted
[installer-tests] Fix the variable name corresponding domain
1 parent 2d888a5 commit 7b6959d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

install/tests/Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,11 @@ aws-kubeconfig:
200200
aws eks update-kubeconfig --name gp-${TF_VAR_TEST_ID} --region eu-west-1 --kubeconfig ${KUBECONFIG} || echo "No cluster present"
201201
@echo -e "\033[0;33mAWS service account credentials fetched, run 'source $$(pwd)/$${TF_VAR_TEST_ID}-creds' to load them into your environment\033[0;m"
202202

203-
get-github-config:
203+
get-github-config: check-var-DOMAIN check-var-TF_VAR_TEST_ID
204204
ifneq ($(GITHUB_SCM_OAUTH),)
205205
@export SCM_OAUTH=./manifests/github-oauth.yaml && \
206206
cat $$GITHUB_SCM_OAUTH > $$SCM_OAUTH && \
207-
yq w -i $$SCM_OAUTH 'oauth.callBackUrl' https://scm.${TF_VAR_domain}/auth/github.com/callback?state=${TF_VAR_TEST_ID} && \
207+
yq w -i $$SCM_OAUTH 'oauth.callBackUrl' https://scm.${DOMAIN}/auth/github.com/callback?state=${TF_VAR_TEST_ID} && \
208208
kubectl --kubeconfig=${KUBECONFIG} create secret generic "github-oauth" \
209209
--from-literal=provider="$$(cat $$SCM_OAUTH)" \
210210
-o yaml --dry-run=client > ${github_oauth_secret}

0 commit comments

Comments
 (0)