Skip to content

Commit bb89b99

Browse files
authored
Fixes preview creation after #20833 (#20845)
* [preview] Fix preview creation after k3s update * [preview] Fix kubectl patch blocking preview creation
1 parent e04327e commit bb89b99

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

dev/preview/infrastructure/modules/gce/vm.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ resource "google_compute_address" "static-preview-ip" {
7777
locals {
7878
vm_name = "preview-${var.preview_name}"
7979
bootstrap_script = templatefile("${path.module}/../../scripts/bootstrap-k3s.sh", {
80-
vm_name = local.vm_name
80+
vm_name = local.vm_name
81+
preview_name = var.preview_name
8182
})
8283

8384
trustmanager_script = file("${path.module}/../../scripts/install-trustmanager.sh")

dev/preview/infrastructure/scripts/bootstrap-k3s.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export SERVICE_DNS_IP
1212
/usr/local/bin/install-k3s.sh \
1313
--token "1234" \
1414
--node-ip "$SERVICE_DNS_IP" \
15+
--tls-san "${preview_name}.preview.gitpod-dev.com" \
1516
--node-label "cloud.google.com/gke-nodepool=control-plane-pool" \
1617
--container-runtime-endpoint=/var/run/containerd/containerd.sock \
1718
--write-kubeconfig-mode 444 \

dev/preview/workflow/preview/deploy-monitoring-satellite.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,4 +97,6 @@ echo "Patching grafana deployment"
9797
kubectl \
9898
--kubeconfig "${PREVIEW_K3S_KUBE_PATH}" \
9999
--context "${PREVIEW_K3S_KUBE_CONTEXT}" \
100-
patch deployments.apps -n monitoring-satellite grafana --type=json -p="[{'op': 'remove', 'path': '/spec/template/spec/nodeSelector'}]"
100+
patch deployments.apps -n monitoring-satellite grafana --type=json \
101+
-p='[{"op": "test", "path": "/spec/template/spec/nodeSelector"}, {"op": "remove", "path": "/spec/template/spec/nodeSelector"}]' \
102+
2>/dev/null || true

0 commit comments

Comments
 (0)