Skip to content

Commit 37fa8a4

Browse files
WVerlaekona-agent
andcommitted
fix: implement PhaseAwareReporter on CompositeReporter
CompositeReporter didn't implement PhaseAwareReporter, so the type assertion in executeBuildPhase failed silently and phase spans were never created. Co-authored-by: Ona <no-reply@ona.com>
1 parent 1bff8aa commit 37fa8a4

1 file changed

Lines changed: 19 additions & 0 deletions

File tree

pkg/leeway/reporter.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,26 @@ func (cr CompositeReporter) PackageBuildStarted(pkg *Package, builddir string) {
555555
}
556556
}
557557

558+
// PackageBuildPhaseStarted implements PhaseAwareReporter
559+
func (cr CompositeReporter) PackageBuildPhaseStarted(pkg *Package, phase PackageBuildPhase) {
560+
for _, r := range cr {
561+
if par, ok := r.(PhaseAwareReporter); ok {
562+
par.PackageBuildPhaseStarted(pkg, phase)
563+
}
564+
}
565+
}
566+
567+
// PackageBuildPhaseFinished implements PhaseAwareReporter
568+
func (cr CompositeReporter) PackageBuildPhaseFinished(pkg *Package, phase PackageBuildPhase, err error) {
569+
for _, r := range cr {
570+
if par, ok := r.(PhaseAwareReporter); ok {
571+
par.PackageBuildPhaseFinished(pkg, phase, err)
572+
}
573+
}
574+
}
575+
558576
var _ Reporter = CompositeReporter{}
577+
var _ PhaseAwareReporter = CompositeReporter{}
559578

560579
type NoopReporter struct{}
561580

0 commit comments

Comments
 (0)