Merge pull request #319 from gitpod-io/kb/fix-s3-batch-test-flake

kylos101 · web-flow · commit 8206b4ecb355 · 2026-01-06T13:47:29.000-05:00
Fix flaky S3 batch optimization test
diff --git a/pkg/leeway/cache/remote/s3_performance_test.go b/pkg/leeway/cache/remote/s3_performance_test.go
@@ -478,7 +478,7 @@ func TestS3Cache_ExistingPackagesBatchOptimization(t *testing.T) {
 			} else {
 				// For small package counts, batch overhead may reduce speedup
 				// Use a lower threshold to avoid flaky tests
-				require.Greater(t, speedup, 0.75, "Batch optimization should not be significantly slower than sequential")
+				require.Greater(t, speedup, 0.45, "Batch optimization should not be significantly slower than sequential")
 			}
 		})
 	}

Original file line number	Diff line number	Diff line change
`@@ -478,7 +478,7 @@ func TestS3Cache_ExistingPackagesBatchOptimization(t *testing.T) {`
`478`	`478`	`} else {`
`479`	`479`	`// For small package counts, batch overhead may reduce speedup`
`480`	`480`	`// Use a lower threshold to avoid flaky tests`
`481`		`- require.Greater(t, speedup, 0.75, "Batch optimization should not be significantly slower than sequential")`
	`481`	`+ require.Greater(t, speedup, 0.45, "Batch optimization should not be significantly slower than sequential")`
`482`	`482`	`}`
`483`	`483`	`})`
`484`	`484`	`}`