Fix gsutil cache download issue#228
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the gsutil cache download issue by correcting how remote URLs for cached packages are constructed and verified.
- Constructs both .tar.gz and .tar URLs using the package version
- Uses gsutil stat to check existing cache files before initiating transfer
Files not reviewed (1)
- .devcontainer/devcontainer.json: Language not supported
Comments suppressed due to low confidence (1)
pkg/leeway/cache/remote/gsutil.go:149
- [nitpick] Consider renaming the loop variable 'urls' to 'urlPair' (or similar) to avoid confusion with the earlier defined 'urls' slice containing strings.
for _, urls := range packageToURLMap {
corneliusludmann
approved these changes
Apr 30, 2025
Contributor
corneliusludmann
left a comment
corneliusludmann
left a comment
There was a problem hiding this comment.
Tested it with gitpod-io/gitpod repo and it worked like a charm. Thanks Pudong. Let's ship it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix gsutil cache download issue
Related Issue(s)
Fixes #227
Fixes CLC-1324
How to test
before
after
Documentation
/hold