bug: search empty state still broken — "No pages match your search" never renders

[zacharias-ona]

Description

Post-merge verification of PR #142 ("fix: resolve E2E editor test strict mode violations from leftover content (#140)") detected 1 E2E failure out of 42 tests. The search empty state continues to fail despite previous fixes in #126 and #136 (both closed as done).

When searching for a nonsense string (zzzyyyxxxnonexistent999), the #search-results container shows skeleton loading placeholders indefinitely instead of the "No pages match your search" message. The screenshot confirms the search input has the query text but the dropdown displays animated pulse bars followed by the full page list.

This is not a regression from PR #142 (which only modified editor E2E test files). The bug has persisted across multiple verification cycles.

Acceptance Criteria

• Searching for a nonsense string (e.g. zzzyyyxxxnonexistent999) shows "No pages match your search" in the dropdown
• The loading state correctly transitions to false after the search API returns zero results
• E2E test search with no matches shows empty state (e2e/search.spec.ts:159) passes against production
• All previously passing smoke test checks continue to pass
• pnpm lint && pnpm typecheck && pnpm test pass

Technical Notes

• Failing E2E test: e2e/search.spec.ts:159 — Sidebar search › search with no matches shows empty state
• Affected component: src/components/sidebar/page-search.tsx — the loading state likely remains true or results is never set to an empty array when the search API returns zero matches, preventing the empty state condition from triggering
• PR that triggered this verification: fix: resolve E2E editor test strict mode violations from leftover content (#140) #142 (not the cause — editor-only changes)
• Previous issues for the same bug: bug: UI regression after PR #123 — search empty state never renders for no-match queries #126 (closed), bug: E2E failures after PR #134 — re-invite toast not shown, search empty state missing #136 (closed) — fixes did not fully resolve the problem
• Other E2E results: 41/42 tests passed; all ad-hoc smoke tests (landing, sign-in, health, auth flow, workspace, editor) passed

[zacharias-ona]

search works in production