chore: migrate database row-page, relation, and files E2E specs to data-testid selectors (#1065)#1066
Merged
sw-factory-automations merged 1 commit intoMay 13, 2026
Conversation
…ta-testid selectors (#1065) Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ UI verification skipped — this PR has no UI changes. Only E2E test selectors and |
Collaborator
Author
|
✅ Post-merge verification skipped — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1065
What
Replaces 10 fragile
locator("text=...")and CSS-class selectors across three E2E spec files withgetByTestIdselectors targeting existingdb-row-property-*anddb-cell-editor-*testids.How
e2e/database-row-page.spec.ts(7 selectors replaced):locator("text=Text")→locator('[data-testid^="db-row-property-name-"]', { hasText: "Text" })scoped togetByTestId("db-row-properties")locator("text=Empty")→toContainText("Empty")on the value cell via[data-testid^="db-row-property-value-"]locator("text=Status")→ same pattern as "Text" abovelocator("div.flex.items-start.gap-4", { hasText: "Status" })→ parent traversal from testid-located name celllocator(".rounded-sm.border.border-border.bg-background")→getByTestId("db-cell-editor-select")statusRow.locator("text=In Progress")→toContainText("In Progress")on the value celllocator("text=Hello from table")→toContainText("Hello from table")ongetByTestId("db-row-properties")e2e/database-relation.spec.ts(3 selectors replaced):locator("text=Linked Items")→getByTestId(\db-row-property-name-${relationPropertyId}`)`locator("text=Alpha Item")→toContainText("Alpha Item")on breadcrumb navlocator(".w-56")→getByTestId("db-cell-editor-relation")e2e/database-files.spec.ts(1 selector replaced):locator("text=Attachments")→getByTestId(\db-row-property-name-${filesPropertyId}`)`No new
data-testidattributes were needed — all existing testids from #700 and #873 were sufficient.Testing
pnpm lint— 0 errorspnpm typecheck— passespnpm test— 139 files, 1877 tests passedpnpm test:e2e— all modified tests pass; remaining flakiness is pre-existing auth timeouts unrelated to this change