Skip to content

chore: migrate database row-page, relation, and files E2E specs to data-testid selectors (#1065)#1066

Merged
sw-factory-automations merged 1 commit into
mainfrom
feat/1065-migrate-row-page-relation-files-testids
May 13, 2026
Merged

chore: migrate database row-page, relation, and files E2E specs to data-testid selectors (#1065)#1066
sw-factory-automations merged 1 commit into
mainfrom
feat/1065-migrate-row-page-relation-files-testids

Conversation

@sw-factory-automations
Copy link
Copy Markdown
Collaborator

Closes #1065

What

Replaces 10 fragile locator("text=...") and CSS-class selectors across three E2E spec files with getByTestId selectors targeting existing db-row-property-* and db-cell-editor-* testids.

How

e2e/database-row-page.spec.ts (7 selectors replaced):

  • locator("text=Text")locator('[data-testid^="db-row-property-name-"]', { hasText: "Text" }) scoped to getByTestId("db-row-properties")
  • locator("text=Empty")toContainText("Empty") on the value cell via [data-testid^="db-row-property-value-"]
  • locator("text=Status") → same pattern as "Text" above
  • locator("div.flex.items-start.gap-4", { hasText: "Status" }) → parent traversal from testid-located name cell
  • locator(".rounded-sm.border.border-border.bg-background")getByTestId("db-cell-editor-select")
  • statusRow.locator("text=In Progress")toContainText("In Progress") on the value cell
  • locator("text=Hello from table")toContainText("Hello from table") on getByTestId("db-row-properties")

e2e/database-relation.spec.ts (3 selectors replaced):

  • locator("text=Linked Items")getByTestId(\db-row-property-name-${relationPropertyId}`)`
  • locator("text=Alpha Item")toContainText("Alpha Item") on breadcrumb nav
  • locator(".w-56")getByTestId("db-cell-editor-relation")

e2e/database-files.spec.ts (1 selector replaced):

  • locator("text=Attachments")getByTestId(\db-row-property-name-${filesPropertyId}`)`

No new data-testid attributes were needed — all existing testids from #700 and #873 were sufficient.

Testing

  • pnpm lint — 0 errors
  • pnpm typecheck — passes
  • pnpm test — 139 files, 1877 tests passed
  • pnpm test:e2e — all modified tests pass; remaining flakiness is pre-existing auth timeouts unrelated to this change

…ta-testid selectors (#1065)

Co-authored-by: Ona <no-reply@ona.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
memo Ready Ready Preview, Comment May 13, 2026 4:29am

Request Review

@sw-factory-automations sw-factory-automations merged commit d346b77 into main May 13, 2026
9 checks passed
@sw-factory-automations sw-factory-automations deleted the feat/1065-migrate-row-page-relation-files-testids branch May 13, 2026 05:02
@sw-factory-automations
Copy link
Copy Markdown
Collaborator Author

✅ UI verification skipped — this PR has no UI changes. Only E2E test selectors and .agents/quality.md were modified; no files under src/components/ or src/app/**/page.tsx / layout.tsx were touched.

@sw-factory-automations
Copy link
Copy Markdown
Collaborator Author

✅ Post-merge verification skipped — chore: PR does not affect the live app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: migrate database row-page and relation E2E specs to use existing data-testid selectors

1 participant