feat(a11y): add aria-live region to editor save status indicator (#1138)#1148
Merged
Merged
Conversation
Add a screen-reader-only role="status" span inside the editor save status container. Only terminal states (Saved, Save failed) are rendered in the live region to avoid noisy announcements from transient Saving... updates on every keystroke. Follows the existing RowCountAnnouncer pattern for live regions. Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ Post-merge verification passed. E2E tests against live site (
Ad-hoc smoke tests:
Interaction smoke test (feat PR):
Total: 41 E2E tests passed, 0 failures. |
Collaborator
Author
|
✅ UI verification passed — design spec compliance confirmed. Checks performed:
This PR adds only a screen-reader-only element — no visual changes to verify beyond confirming the element is properly hidden. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1138
What
Adds a screen-reader-only
role="status"live region to the editor save status indicator so screen readers announce save outcomes.How
sr-only<span role="status">inside the existing save status container div.RowCountAnnouncerpattern (src/components/database/views/row-count-announcer.tsx) for live regions.Acceptance Criteria Verification
role="status"(impliesaria-live="polite") for screen reader announcementse2e/accessibility.spec.ts— page editor) passes with no new axe violationspnpm lint && pnpm typecheck && pnpm testpass (0 errors, 144 files, 1962 tests)Testing
pnpm lint— 0 errorspnpm typecheck— cleanpnpm test— 144 files, 1962 tests passede2e/accessibility.spec.ts— page editor accessibility test passed (axe-core found no violations)