feat: add inline rename to sidebar page tree context menu (#1164)#1167
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…e story The Renaming story was added to page-tree-item.stories.tsx but the corresponding visual regression baseline snapshot was not committed. Co-authored-by: Ona <no-reply@ona.com>
Collaborator
Author
|
✅ UI verification passed — design spec compliance confirmed. Checks performed:
Storybook visual regression: 1/1 passed — all story baselines match, including new "Inline rename active" story. Live site vs Storybook: No discrepancies. The inline rename input renders identically in the real sidebar context — no layout differences, clipping, or overflow issues. Live site screenshots (desktop dark + mobile): Sidebar page tree renders correctly. No broken layouts, proper hierarchy, correct token usage. Mobile correctly hides sidebar (Sheet pattern). |
Collaborator
Author
|
✅ Post-merge verification passed. E2E tests (live site):
Ad-hoc smoke tests:
Interaction smoke test (inline rename feature):
Skipped:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1164
What
Adds a "Rename" action to the sidebar page tree context menu that converts the page title into an inline text input for quick renaming without navigating to the page.
How
handleRenametousePageTreeActions— optimistically updates local state, persists via Supabase, dispatchespages-changedevent androuter.refresh()to sync breadcrumb/editor title.isRenaming/onStartRename/onRenameprops toPageTreeItem. When renaming, the title button is replaced with a focused, pre-selected<input>. Enter and blur commit; Escape cancels.renamingIdstate is managed inPageTreeand passed down through the tree.Testing
e2e/sidebar-rename.spec.ts: menu item visibility, inline input focus, Enter saves, Escape cancels, blur saves.Renamingstory topage-tree-item.stories.tsx.pnpm lint && pnpm typecheck && pnpm testpass (0 errors, 1975 unit tests).