fix(editor): wrap dispatchCommand in editor.update() to prevent read-only errors

[zacharias-ona]

Summary

Fixes Error: Cannot use method in read-only mode. thrown when saving/removing links or formatting text via the floating toolbar.

Sentry issue: https://ona-2j.sentry.io/issues/MEMO-5 (4 events, 3 users)

Closes #128

Root Cause

editor.dispatchCommand() triggers command listeners synchronously via triggerCommandListeners → updateEditorSync. When activeEditor === editor (true during an editorState.read() callback from the update listener), updateEditorSync takes a fast path that calls the listener directly without creating a writable context. The LinkPlugin listener calls $toggleLink → splitText → errorOnReadOnly.

Both floating-link-editor-plugin.tsx and floating-toolbar-plugin.tsx called editor.dispatchCommand() from React event handlers without wrapping in editor.update().

Changes

• floating-link-editor-plugin.tsx: Wrap handleSave and handleRemove dispatchCommand calls in editor.update()
• floating-toolbar-plugin.tsx: Wrap all format and link toggle dispatchCommand calls in editor.update()
• lexical-dispatch-safety.test.ts: Static analysis test that scans editor files for bare dispatchCommand() calls with mutating commands outside editor.update()
• .agents/conventions.md: Document the "dispatching mutating commands" pattern to prevent recurrence

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
memo	Ready	Preview, Comment	Apr 16, 2026 11:09pm

[zacharias-ona]

Reviewed and merged. Fix correctly wraps all mutating dispatchCommand calls in editor.update(), static analysis test prevents regression, and convention is documented. Issue #128 marked as done.

[zacharias-ona]

✅ UI verification passed — design spec compliance confirmed.

Static analysis: No visual changes in this PR. All modifications are behavioral (wrapping editor.dispatchCommand() in editor.update()). Existing styling in both floating-link-editor-plugin.tsx and floating-toolbar-plugin.tsx remains compliant with .agents/design.md — color tokens, typography, spacing, accessibility attributes, touch targets, and dark mode usage are all correct.

Visual verification: Playwright screenshots of the editor page (desktop dark + mobile) show no regressions. Layout, spacing, and component rendering are intact.

[zacharias-ona]

✅ Post-merge verification passed. The changes in this PR (editor dispatchCommand wrapping) do not cause any new regressions.

E2E suite: 35/42 passed, 4 failed, 3 skipped (dependent on a failed test)

Ad-hoc smoke tests: All passed

• ✅ Landing page — loads, has title
• ✅ Sign-in page — renders email input
• ✅ Health endpoint — returns healthy status
• ✅ Authenticated flow — login, workspace load, editor navigation

Pre-existing failures (not caused by this PR):

• search.spec.ts — 3 tests fail due to search results not rendering (tracked in bug: UI regression after PR #123 — search empty state never renders for no-match queries #126, introduced by PR fix: flaky E2E tests for invite revocation and search (#118) #123)
• members.spec.ts:139 — "owner can re-invite" fails due to ambiguous button selector (filed bug: E2E test "owner can re-invite" fails due to ambiguous button selector #133)
• 3 member tests skipped (depend on the failing re-invite test)