fix: use exact match for Invite button selector in E2E tests (#133)#134
Merged
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ UI verification skipped — no UI files changed (only |
5 tasks
Collaborator
Author
|
❌ Post-merge verification failed. 2 E2E tests failed, 3 skipped (serial dependents). 37/42 passed. Failures:
Ad-hoc smoke tests passed: landing page, sign-in, health endpoint, authenticated login, workspace load, editor navigation. See #136. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
What
The E2E test "owner can re-invite and invited user can accept" failed with a Playwright strict mode violation. The selector
getByRole('button', { name: /invite/i })matched two buttons: the "Invite" submit button and the "Revoke invite for ..." button (whose accessible name also contains "invite"). This blocked the re-invite test and 3 dependent serial tests from running.How
Replaced the regex selector
/invite/iwith{ name: 'Invite', exact: true }at both call sites (lines 96 and 147) ine2e/members.spec.ts. The exact match targets only the submit button, avoiding collision with "Revoke invite" buttons.Testing
owner can re-invite and invited user can acceptand its 3 dependent tests (owner can change a member's role,member role cannot access invite or remove controls,owner can remove a member).pnpm lint && pnpm typecheck && pnpm testall pass.