test: add unit tests for auth form validation (#121)#138
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ Post-merge verification skipped — |
Collaborator
Author
|
✅ UI verification skipped — this PR contains only test files ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
What
Adds unit tests for the sign-in and sign-up form components, covering validation attributes, error display, Supabase auth method calls, and post-auth redirect logic.
How
src/app/(auth)/sign-up/page.test.tsx— 9 tests covering:supabase.auth.signUpcalled with correct email, password, and display_name/when no workspace foundsrc/app/(auth)/sign-in/page.test.tsx— 8 tests covering:supabase.auth.signInWithPasswordcalled with correct email and password/when no workspace foundBoth test files mock
@/lib/supabase/client,next/navigation,next/link, and@/components/auth/oauth-buttonsfollowing the established pattern fromworkspace-settings-form.test.tsx.Testing
pnpm lint— ✅ passpnpm typecheck— ✅ passpnpm test— ✅ 122 tests pass (16 files), including 17 new tests