fix: resolve hydration mismatch on relative time display (#130)#139
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ UI verification passed — design spec compliance confirmed. Static analysis: No violations found. The Visual verification (Playwright screenshots):
|
Collaborator
Author
|
✅ Post-merge verification passed. E2E suite: 41/42 passed. 1 known flaky failure ( Ad-hoc smoke tests — all passed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130
What
The workspace home page rendered relative time strings (e.g. "47m ago") that differed between SSR and client hydration because wall-clock time advances between the two passes. This caused React hydration mismatch errors reported in Sentry (MEMO-8).
How
Extracted a reusable
RelativeTimeclient component that usessuppressHydrationWarningon the time span element. React ignores the text content difference between server and client for that element. AsetIntervalkeeps the display current after mount. The inlineformatRelativeDatefunction was moved out ofworkspace-home.tsxinto the new component as a named export for testability.Testing
relative-time.test.tswith 7 tests:formatRelativeDatecovering all time buckets (just now, minutes, hours, days, formatted date)suppressHydrationWarninganduseEffect/setIntervalpnpm lint && pnpm typecheck && pnpm test && pnpm test:e2eall green