fix(e2e): create fresh page in navigateToEditorPage to prevent parallel test interference (#187)#190
Merged
Merged
Conversation
…el test interference (#187) Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
✅ UI verification skipped — no UI files changed. Only |
Collaborator
Author
|
✅ Post-merge verification passed. E2E suite: 47/47 tests passed against Ad-hoc smoke tests:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187
What
The
navigateToEditorPageE2E helper navigated to the first existing page in the sidebar tree. When tests ran in parallel (fullyParallel: true), the page-crud delete test could delete that same page between the sidebar load and the server-side route query, causing a 404 in any test that happened to click the same tree item.How
Changed
navigateToEditorPageto always create a fresh page via the sidebar "New Page" button instead of clicking an existing one. This gives each test its own isolated page that no parallel test can delete or modify. The helper still waits for the page tree to finish loading (workspace ID resolution) before clicking "New Page" to avoid the silent no-op whenworkspaceIdis null.Testing
pnpm lint && pnpm typecheck && pnpm test && pnpm test:e2eall pass