fix(ui): remove transition-opacity from page icon hover reveal (#191)#196
Merged
Conversation
Co-authored-by: Ona <no-reply@ona.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The staging job runs `supabase db reset --linked` which drops the public schema but not the storage schema. The INSERT INTO storage.buckets and CREATE POLICY statements failed on re-runs because the objects already existed. Added ON CONFLICT DO NOTHING for the bucket insert and wrapped policies in DO blocks with duplicate_object exception handlers. Co-authored-by: Ona <no-reply@ona.com>
Collaborator
Author
|
✅ UI verification passed — design spec compliance confirmed. Static analysis: The removal of Visual verification (Playwright screenshots):
|
Collaborator
Author
|
✅ Post-merge verification passed. E2E test suite: 46/47 passed. The 1 failure ( Ad-hoc smoke tests — routes tested:
Skipped:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #191
What
The "Add icon" hover-reveal button in
page-icon.tsxusedtransition-opacityfor its opacity change on hover. The design spec requires all hover states to be instant — no transitions, no decorative animations.How
Removed the
transition-opacityclass from the hover-reveal wrapper div. This makes the opacity change from 0 to 100 instant on hover, matching the existing pattern inpage-tree.tsxand the design spec.Testing
Added a static analysis regression test (
page-icon-design-spec.test.ts) that verifies any line withopacity-0andgroup-hoverdoes not containtransition-opacityorduration-*classes. This follows the same pattern used indesign-spec-compliance.test.tsfor the drag handle.