fix: wrap search E2E tests with toPass retry for read-replica lag (#199)

[zacharias-ona]

Closes #199

What

The "clicking a search result navigates to the correct page" E2E test intermittently timed out waiting for [role="option"] elements to appear in the search dropdown. The search feature itself works — the flake was caused by Supabase read-replica lag after a title save, where the first search query returns no results because the full-text search vector hasn't propagated yet.

How

Wrapped the search-and-wait-for-results flow in expect(...).toPass() with retry intervals ([2s, 3s, 5s] over a 15s timeout), matching the pattern already used successfully in the "typing in search input shows matching results" test. Applied the same fix to the "search is scoped to the current workspace" test which had the same vulnerability.

Testing

• All 5 search E2E tests pass consistently, including the previously flaky navigation test
• Full E2E suite: 46/47 passed (the 1 failure is a pre-existing flake in members.spec.ts, unrelated to search)
• pnpm lint && pnpm typecheck && pnpm test all pass (215 unit tests)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
memo	Ready	Preview, Comment	Apr 17, 2026 6:17pm

[zacharias-ona]

✅ UI verification skipped — no UI files changed (only e2e/search.spec.ts).

[zacharias-ona]

✅ Post-merge verification passed.

E2E suite: 46/47 passed

• 1 failure: search with no matches shows empty state — pre-existing bug tracked in bug: search empty state still broken — "No pages match your search" never renders #144 (not a regression from this PR, which only modified test retry logic)

Ad-hoc smoke tests: all passed

• ✅ Landing page — loads with title
• ✅ Sign-in page — renders email input
• ✅ Health endpoint — returns healthy status
• ✅ Authenticated flow — login, workspace load
• ⏭️ Skipped: /dashboard (not yet built), editor route (no page buttons in workspace at test time)