fix: replace arbitrary spacing values with Tailwind scale equivalents (#201)

[zacharias-ona]

Closes #201

What

PR #197 introduced min-h-[44px] and min-w-[44px] arbitrary Tailwind values in emoji-picker.tsx and page-icon.tsx where exact scale equivalents exist. The design spec requires using the Tailwind spacing scale instead of arbitrary values when a match is available.

How

Replaced all min-h-[44px] / min-w-[44px] with min-h-11 / min-w-11 (11 × 4px = 44px). Three occurrences across two files:

• emoji-picker.tsx: emoji button className
• page-icon.tsx: page icon button className
• page-icon.tsx: "Add icon" button className

Testing

Updated the existing static analysis tests in emoji-picker-design-spec.test.ts to assert the Tailwind scale classes (min-h-11, min-w-11) and reject the arbitrary equivalents (min-h-[44px], min-w-[44px]). All 222 unit tests pass. No visual change — min-h-11 computes to the same 44px value.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
memo	Ready	Preview, Comment	Apr 17, 2026 7:17pm

[zacharias-ona]

✅ UI verification passed — design spec compliance confirmed.

Static analysis — all checks pass:

• Spacing: min-h-11/min-w-11 are correct Tailwind scale equivalents of 44px (11 × 4px). No arbitrary values remain.
• Color tokens, typography, corners, accessibility, dark mode: no violations.

Visual verification (Playwright screenshots on production):

• Desktop dark: editor page renders correctly, no layout issues.
• Mobile (375×812): "Add icon" button visible, proper touch target measured at 86px × 44px (≥44px minimum).
• Icon hover state: "Add icon" appears correctly on hover with proper styling.
• No visual regressions — zero-visual-change refactor confirmed.

[zacharias-ona]

✅ Post-merge verification passed.

E2E suite: 46/47 passed. The 1 failure (search with no matches shows empty state) is a pre-existing issue tracked in #144 — unrelated to this PR's spacing class changes.

Ad-hoc smoke tests:

• ✅ Landing page — loaded, title present
• ✅ Sign-in page — rendered with email input
• ✅ Health endpoint — returned OK
• ✅ Authenticated login flow — signed in, redirected to workspace
• ✅ No console errors (unauthenticated or authenticated)

Skipped:

• /dashboard (route does not exist)
• Editor navigation (no page buttons with timestamps found in workspace during smoke test)