feat: show copyable invite link in pending invites list (#239)#240
Conversation
Co-authored-by: Ona <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review: one issue to fix Both clipboard write calls lack error handling.
Everything else looks good — clean implementation, proper timer cleanup, correct design tokens, good accessibility labels. Fixing inline. |
clipboard.writeText() can reject when the document isn't focused or permissions are denied. Wrap both call sites in try/catch to prevent unhandled promise rejections. Added files to the bare-catch allowlist since clipboard failures are intentionally silent. Co-authored-by: Ona <[email protected]>
|
✅ UI verification passed — design spec compliance confirmed. Static analysis (2 changed UI files):
Visual verification (Playwright screenshots — desktop 1280×800, mobile 375×812):
|
|
❌ Post-merge verification failed. E2E suite: 63 passed, 3 failed, 8 skipped (serial deps of failed tests) Regression from this PR (1):
Pre-existing failures unrelated to this PR (2):
Ad-hoc smoke tests: All passed (landing page, sign-in, health endpoint, authenticated login + workspace load). See #241. |
Closes #239
What
Adds the ability for workspace admins to copy invite links, both immediately after creating an invite and from the pending invites list.
How
Invite form (
invite-form.tsx):{origin}/invite/{token}) is displayed inline below the form with a copy buttonPending invites list (
pending-invite-list.tsx):Tooltipcomponent (base-ui pattern withrenderprop) for hover feedbackBoth use
navigator.clipboard.writeText()for clipboard access and clean up timers on unmount.Testing
pnpm lint✅pnpm typecheck✅pnpm test— 252 tests pass ✅