Skip to content

Commit 09733cc

Browse files
authored
Merge pull request #32 from gitpod-io/nv/remove-honeycomb-key
fix: remove Honeycomb API key from Terraform variable and VM metadata (N9)
2 parents 5641f2e + d715104 commit 09733cc

5 files changed

Lines changed: 4 additions & 21 deletions

File tree

examples/runner-with-networking/main.tf

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,9 @@ module "runner" {
172172
create_cmek = var.create_cmek
173173
kms_key_name = var.kms_key_name
174174

175-
custom_images = var.custom_images
176-
enable_agents = var.enable_agents
177-
honeycomb_api_key = var.honeycomb_api_key
178-
labels = var.labels
175+
custom_images = var.custom_images
176+
enable_agents = var.enable_agents
177+
labels = var.labels
179178

180179
depends_on = [module.networking, module.dns, module.self_signed_cert, module.certbot]
181180
}

examples/runner-with-networking/variables.tf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,3 @@ variable "enable_agents" {
201201
default = true
202202
}
203203

204-
variable "honeycomb_api_key" {
205-
description = "Honeycomb API key for development tracing. Enables tracing on the runner and environments when set."
206-
type = string
207-
default = ""
208-
sensitive = true
209-
}

files/runner-cloud-init.tftpl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -611,10 +611,6 @@ write_files:
611611
https_proxy=${HTTPS_PROXY}
612612
all_proxy=${ALL_PROXY}
613613
no_proxy=${NO_PROXY}
614-
%{ if HONEYCOMB_API_KEY != "" ~}
615-
HONEYCOMB_API_KEY=${HONEYCOMB_API_KEY}
616-
%{ endif ~}
617-
618614
%{ if AUTH_PROXY_TLS_CERT != "" ~}
619615
# Auth proxy TLS certificate for verification (CA trust)
620616
- path: /var/lib/gitpod/auth-proxy-ca.crt

runner-vm.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ data "cloudinit_config" "runner" {
140140
ENABLE_AGENTS = var.enable_agents
141141
AGENT_BUCKET_NAME = local.agent_bucket_name
142142
RUNNER_ASSETS_BUCKET_NAME = google_storage_bucket.runner_assets.name
143-
HONEYCOMB_API_KEY = var.honeycomb_api_key
144143
MIG_WARM_POOL_ENABLED = true
145144
# Proxy configuration
146145
HTTP_PROXY = local.http_proxy

variables.tf

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -337,9 +337,4 @@ variable "enable_agents" {
337337
default = true
338338
}
339339

340-
variable "honeycomb_api_key" {
341-
description = "Honeycomb API key for development tracing. Enables tracing on the runner and environments when set."
342-
type = string
343-
default = ""
344-
sensitive = true
345-
}
340+

0 commit comments

Comments
 (0)