Skip to content

Commit 416ee84

Browse files
fix: remove Honeycomb API key from Terraform and VM metadata
The Honeycomb API key is now managed via the management plane: the dashboard encrypts it with the runner's public key, the runner decrypts it and persists it to Secret Manager. The Terraform variable and cloud-init env var were a legacy bootstrap path that exposed the key in plaintext in VM metadata (user-data). Removed: - var.honeycomb_api_key from variables.tf - HONEYCOMB_API_KEY template variable from runner-vm.tf - HONEYCOMB_API_KEY env var block from runner-cloud-init.tftpl The runner orchestrator's os.Getenv fallback will be removed in a companion PR on gitpod-next. Co-authored-by: Ona <no-reply@ona.com>
1 parent 59066c3 commit 416ee84

3 files changed

Lines changed: 1 addition & 11 deletions

File tree

files/runner-cloud-init.tftpl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -611,10 +611,6 @@ write_files:
611611
https_proxy=${HTTPS_PROXY}
612612
all_proxy=${ALL_PROXY}
613613
no_proxy=${NO_PROXY}
614-
%{ if HONEYCOMB_API_KEY != "" ~}
615-
HONEYCOMB_API_KEY=${HONEYCOMB_API_KEY}
616-
%{ endif ~}
617-
618614
%{ if AUTH_PROXY_TLS_CERT != "" ~}
619615
# Auth proxy TLS certificate for verification (CA trust)
620616
- path: /var/lib/gitpod/auth-proxy-ca.crt

runner-vm.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ data "cloudinit_config" "runner" {
140140
ENABLE_AGENTS = var.enable_agents
141141
AGENT_BUCKET_NAME = local.agent_bucket_name
142142
RUNNER_ASSETS_BUCKET_NAME = google_storage_bucket.runner_assets.name
143-
HONEYCOMB_API_KEY = var.honeycomb_api_key
144143
MIG_WARM_POOL_ENABLED = true
145144
# Proxy configuration
146145
HTTP_PROXY = local.http_proxy

variables.tf

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -337,9 +337,4 @@ variable "enable_agents" {
337337
default = true
338338
}
339339

340-
variable "honeycomb_api_key" {
341-
description = "Honeycomb API key for development tracing. Enables tracing on the runner and environments when set."
342-
type = string
343-
default = ""
344-
sensitive = true
345-
}
340+

0 commit comments

Comments
 (0)