Skip to content

Commit d6d818e

Browse files
authored
Merge pull request #28 from gitpod-io/nv/firewall-flow-logging
feat: add flow logging to security-critical firewall rules (A17)
2 parents 2f3dccf + c3d358a commit d6d818e

1 file changed

Lines changed: 20 additions & 0 deletions

File tree

firewall.tf

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,10 @@ resource "google_compute_firewall" "deny_environments_to_services" {
9999
target_tags = ["gitpod-runner", "gitpod-proxy"]
100100
priority = 1000 # Higher priority than allow rules
101101

102+
log_config {
103+
metadata = "INCLUDE_ALL_METADATA"
104+
}
105+
102106
# depends on proxy vm
103107
depends_on = [google_compute_backend_service.proxy]
104108
}
@@ -119,6 +123,10 @@ resource "google_compute_firewall" "allow_iap_to_environments" {
119123
source_ranges = ["35.235.240.0/20"]
120124
target_tags = ["gitpod-type-environment"]
121125

126+
log_config {
127+
metadata = "INCLUDE_ALL_METADATA"
128+
}
129+
122130
# depends on proxy vm
123131
depends_on = [google_compute_backend_service.proxy]
124132
}
@@ -164,6 +172,10 @@ resource "google_compute_firewall" "deny_email_from_environments" {
164172
destination_ranges = ["0.0.0.0/0"]
165173
target_tags = ["gitpod-type-environment"]
166174

175+
log_config {
176+
metadata = "INCLUDE_ALL_METADATA"
177+
}
178+
167179
# depends on proxy vm
168180
depends_on = [google_compute_backend_service.proxy]
169181
}
@@ -430,6 +442,10 @@ resource "google_compute_firewall" "deny_proxy_to_environments_ssh_egress" {
430442

431443
destination_ranges = [data.google_compute_subnetwork.runner_subnet.ip_cidr_range]
432444
target_tags = ["gitpod-proxy"]
445+
446+
log_config {
447+
metadata = "INCLUDE_ALL_METADATA"
448+
}
433449
}
434450

435451
# Allow proxy egress to environments on application ports only
@@ -511,4 +527,8 @@ resource "google_compute_firewall" "allow_environments_internet_egress" {
511527

512528
destination_ranges = ["0.0.0.0/0"]
513529
target_tags = ["gitpod-type-environment"]
530+
531+
log_config {
532+
metadata = "INCLUDE_ALL_METADATA"
533+
}
514534
}

0 commit comments

Comments
 (0)