Merge pull request #21 from gitpod-io/n/warm-pool-default

feat: enable warm pool by default for all new runners

Author: nandajavarma

examples/runner-with-networking/main.tf

@@ -168,14 +168,14 @@ module "runner" {
   proxy_vm_config  = local.selected_profile.proxy_vm_config
   redis_config     = local.selected_profile.redis_config
 
-  routable_subnet_name  = local.runner_subnet_name
-  create_cmek           = var.create_cmek
-  kms_key_name          = var.kms_key_name
-  mig_warm_pool_enabled = var.mig_warm_pool_enabled
-  custom_images         = var.custom_images
-  enable_agents         = var.enable_agents
-  honeycomb_api_key     = var.honeycomb_api_key
-  labels                = var.labels
+  routable_subnet_name = local.runner_subnet_name
+  create_cmek          = var.create_cmek
+  kms_key_name         = var.kms_key_name
+
+  custom_images     = var.custom_images
+  enable_agents     = var.enable_agents
+  honeycomb_api_key = var.honeycomb_api_key
+  labels            = var.labels
 
   depends_on = [module.networking, module.dns, module.self_signed_cert, module.certbot]
 }

examples/runner-with-networking/variables.tf

@@ -158,11 +158,6 @@ variable "create_cmek" {
   default     = false
 }
 
-variable "mig_warm_pool_enabled" {
-  description = "Enable warm pool support using GCP Managed Instance Groups (MIGs) for faster environment startup"
-  type        = bool
-  default     = false
-}
 
 variable "kms_key_name" {
   description = "The KMS key name for CMEK encryption of GCP resources. Only used when create_cmek = false. Ignored when create_cmek = true."

runner-vm.tf

@@ -141,7 +141,7 @@ data "cloudinit_config" "runner" {
       AGENT_BUCKET_NAME                    = local.agent_bucket_name
       RUNNER_ASSETS_BUCKET_NAME            = google_storage_bucket.runner_assets.name
       HONEYCOMB_API_KEY                    = var.honeycomb_api_key
-      MIG_WARM_POOL_ENABLED                = var.mig_warm_pool_enabled
+      MIG_WARM_POOL_ENABLED                = true
       # Proxy configuration
       HTTP_PROXY  = local.http_proxy
       HTTPS_PROXY = local.https_proxy

variables.tf

@@ -343,9 +343,3 @@ variable "honeycomb_api_key" {
   default     = ""
   sensitive   = true
 }
-
-variable "mig_warm_pool_enabled" {
-  description = "Enable warm pool support using GCP Managed Instance Groups (MIGs) for faster environment startup"
-  type        = bool
-  default     = false
-}