chore: pin GitHub Actions to SHA (PDE-218)#1849
Merged
Merged
Conversation
Contributor
Author
|
Builds are failing. @kylos101: Is this expected since we still miss secrets? |
Member
|
@corneliusludmann We need to get rid of This is an example change for gitpod-io/gitpod that does the same: gitpod-io/gitpod#21169 Afterwards we should not need the google-auth anymore. If we still do, then it's for pushing images, and can use a more scoped-down service-account. 👍 |
Pin all external GitHub Actions to specific commit SHAs to prevent supply chain attacks via malicious tag updates. Actions pinned: - actions/cache@v4 - actions/checkout@v5 - actions-ecosystem/action-add-labels@v1 - actions/setup-node@v5 - cschleiden/actions-linter@v1 - google-github-actions/auth@v3.0.0 - google-github-actions/setup-gcloud@v3.0.1 - slackapi/slack-github-action@v2.1.1 Exceptions (internal Gitpod workflows, not pinned): - gitpod-io/gce-github-runner/.github/workflows/create-vm.yml@main - gitpod-io/gce-github-runner/.github/workflows/delete-vm.yml@main Part of PDE-138 Closes PDE-218 Co-authored-by: Ona <no-reply@ona.com>
geropl
force-pushed
the
cl/pde-218-pin-gha
branch
from
694f9ff to
72df900
Compare
Member
|
rebasing after #1850 👀 |
geropl
approved these changes
Dec 19, 2025
Member
geropl
left a comment
geropl
left a comment
There was a problem hiding this comment.
Change itself LGTM, was just waiting for the pipeline to get unblocked ✔️
Should work now 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin all external GitHub Actions to specific commit SHAs for supply chain security.
Changes
actions/cache@v4→ pinned to SHAactions/checkout@v5→ pinned to SHAactions-ecosystem/action-add-labels@v1→ pinned to SHAactions/setup-node@v5→ pinned to SHAcschleiden/actions-linter@v1→ pinned to SHAgoogle-github-actions/auth@v3.0.0→ pinned to SHAgoogle-github-actions/setup-gcloud@v3.0.1→ pinned to SHAslackapi/slack-github-action@v2.1.1→ pinned to SHAExceptions
Internal Gitpod workflows (not pinned to SHA):
gitpod-io/gce-github-runner/.github/workflows/create-vm.yml@maingitpod-io/gce-github-runner/.github/workflows/delete-vm.yml@mainRelated