Disable npm lifecycle scripts and npx for security#1851
Closed
jespino wants to merge 6 commits into
Closed
Conversation
- Add npm/yarn ignore-scripts config to Dockerfile - Disable npx in postCreateCommand Related to PDE-128 Co-authored-by: Ona <no-reply@ona.com>
Co-authored-by: Ona <no-reply@ona.com>
- Add package.json and package-lock.json in .autofix directory - Update workflow to use npm ci with lockfile for reproducible builds Co-authored-by: Ona <no-reply@ona.com>
Co-authored-by: Ona <no-reply@ona.com>
Co-authored-by: Ona <no-reply@ona.com>
Member
|
@jespino can you rebase please? the build issues should be resolved now |
Member
|
@jespino same here, rebuild should fix these |
Author
|
@geropl CI passes, we can merged this whenever you want |
Collaborator
|
Closing given conversation with @geropl earlier today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PDE-128