Open
Description
Describe the bug
Opening the app in a repo containing a large uncommitted file has gitui quickly consuming all available memory on my system. I have to quit quickly before my system halts.
To Reproduce
- place a multi GB file in a repo
- open
gitui
- scroll down and select this file
- (optional) scroll away and select another file, notice that memory usage continues to climb
Expected behaviour
It took me a while to notice the issue, as it was taking down my machine before I could play-around, I was assuming it was another cause.
It appears that gitui was trying to present the diff of the new uncommitted file to me. I believe the flame graph below confirms that git_diff_file_content__init_from_src()
.
Some potential solutions:
- Perhaps have a limit on the size of file contents we're willing to present to the user in the diff viewer
- or perhaps only present the file content on-focus of the diff viewer (on the right)
Context (please complete the following information):
- Fedora Linux 38.20230520.0 (Silverblue)
- gitui 0.20.1
- Rust version: 1.69.0
Additional context
make profile
which produced the following flamegraph: