Skip to content

Pre-push hooks seem to be ignored #1933

Open
@nateridderman

Description

@nateridderman

Describe the bug
When I push changes via gitui, it does not seem to run my repo's pre-push hook

My pre-push hook looks something like:
#!/usr/bin/env bash
./gradlew detekt || exit $?

To Reproduce
To stage/commit/push some changes via gitui with the aforementioned hook.

Expected behavior
When I run "git push" from the command line, my pre-push script is run (and stdout is shown in the terminal) and if it has an error, the push is aborted. For gitui, I would not expect it to show stdout, but the push dialog could have a state indicating that it's running pre-push hooks and waiting for the result.

Screenshots
If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

  • macOS 13.4.1
  • GitUI Version 0.24.3
  • Rust version: 1.72.1

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions