bare repos + workdir with gix

[extrawurst]

Places that are already migrated to gix use gix_repo but in contrast to repo this one does not pass workdir which means the option of opening a repo as a tuple of .git path separate from workdir will not work for this.

see https://libgit2.org/docs/reference/main/repository/git_repository_set_workdir.html

we introduced support for this in #1026

[extrawurst]

found this when investigating #2732

[cruessler]

@Byron Is there anything similar to Repository::set_workdir (https://docs.rs/git2/latest/git2/struct.Repository.html#method.set_workdir) in gix? A full-text seach for set_workdir in gix doesn’t find any method that is aliased as set_workdir. There is upwards::Options::current_dir which looks related (https://docs.rs/gix/latest/gix/discover/upwards/struct.Options.html#structfield.current_dir), but I’m not sure it can be used for this purpose. This is the specific piece of code I’m trying to replicate:

gitui/asyncgit/src/sync/repository.rs

Lines 64 to 66 in 2374e00

	if let Some(workdir) = repo_path.workdir() {
	repo.set_workdir(workdir, false)?;
	}

[extrawurst]

If we do not fix this it keeps folks from using gitui to manage their .dot file repos and it would be a regression. plus we should have a test for this

[Byron]

Actually there now is an implementation of this here: GitoxideLabs/gitoxide@0ed0164 . It's ready to be merged, but I think a release is only feasible 22nd of November as there are already breaking changes that prevent a patch release.

I hope to merge it in the coming days at least, and maybe you can cut a new release with gitoxide as Git dependency?

[extrawurst]

Actually there now is an implementation of this

Wow! You are fast!

I hope to merge it in the coming days at least, and maybe you can cut a new release with gitoxide as Git dependency?

unfortunately not because gitui is released on crates and depends on its sub crates to be released aswell :(

22nd of November

are there more breaking changes in the pipeline for this specific date?

[Byron]

Actually there now is an implementation of this

Wow! You are fast!

@cruessler and I paired on it in our lunch break 😁.

I hope to merge it in the coming days at least, and maybe you can cut a new release with gitoxide as Git dependency?

unfortunately not because gitui is released on crates and depends on its sub crates to be released aswell :(

I see, and can totally understand that the 22nd of November isn't fast enough.
But here is an outrageous idea: what if gitui would monkey-patch the gix::Repository? It could be 'cast' into a copy of its structure with the respective field made pub. Then it's just a matter of setting repo.workdir = Some(dir); to make it work mostly like in the more elaborate implementation you are waiting for.
It's an ugly solution, and I don't feel good to write about it in public 😅.

[extrawurst]

But here is an outrageous idea:

Outrageous! I like it! @cruessler if you accept to get your hands this dirty I would accept that as a intermediate solution. but then the unittest for this is a must and we likely have to lower the forbid(unsafe) to a deny(unsafe) for this release in the asyncgit crate.

[cruessler]

Outrageous! I like it! @cruessler if you accept to get your hands this dirty I would accept that as a intermediate solution. but then the unittest for this is a must and we likely have to lower the forbid(unsafe) to a deny(unsafe) for this release in the asyncgit crate.

I’m on it! ;-)

[cruessler]

I hope to have a PR ready by tomorrow!