bad credentials despite normal cli being fine

[jamesb93]

Describe the bug
I can push from the command line normally git push, but pushing within gitui always fails due to 'bad credentials'.

To Reproduce
Commit some changes in gitui, press p to trigger a push. It always fails.

Expected behavior
Pushing should succeed as my ssh key is valid and works outside of gitui.

Screenshots
If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

• OS/Distro : macOS 11, arm m1
• GitUI Version: 0.11.0
• Rust version: 1.49 stable

Additional context
gitui installed from cargo.

[dmytro-tolkodubov]

The same.
Mac OS 10.15.4
GitUI version 0.11.0 (installed via brew)

[extrawurst]

Unfortunately I cannot reproduce the issue. Anything special about the way you push?

[dmytro-tolkodubov]

Thanks for a quick reply, Stephan!
Anything special about the way you push --> nope, just pressing p once commited and ready to push.

[dmytro-tolkodubov]

i think the issues is in the fact gitui does git push <branch_name> instead of git push origin <branch_name>. Is there any way to make the latter the default push option?

[extrawurst]

can you share the way your remote is setup in .git/config?
for it looks like:

[remote "origin"]
        url = git@github.com:extrawurst/gitui.git

[extrawurst]

i think the issues is in the fact gitui does git push <branch_name> instead of git push origin <branch_name>. Is there any way to make the latter the default push option?

since you use the brew-version it only supports pushing to origin right now

[dmytro-tolkodubov]

My remote is setup in this way:

[core]
repositoryformatversion = 0
filemode = true
bare = false
logallrefupdates = true
ignorecase = true
precomposeunicode = true
[remote "origin"]
url = git@github.com:**/pipeline-base.git
fetch = +refs/heads/:refs/remotes/origin/
[branch "develop"]
remote = origin
merge = refs/heads/develop
[branch "release/1.12.0"]
remote = origin
merge = refs/heads/release/1.12.0
[branch "release/1.12.1"]
remote = origin
merge = refs/heads/release/1.12.1

And if i do git push <branch_name> from the cli, i get
**fatal: 'test' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.** --> which results in bed credentials in gitui i think.
But if i do git push origin <branch_name> all works fine. Might be something with my git setup, but so far was working like a charm.
Thanks

[extrawurst]

@dmytro-tolkodubov I cannot see anything obviously problematic unfortunately.
Could you run gitui -l so that it writes to the log file and share if there is anything more telling in there?

[dmytro-tolkodubov]

@extrawurst did execute with -l flag, but can't find the file with with the log output :).

[extrawurst]

@extrawurst did execute with -l flag, but can't find the output where the log should have been saved to :).

https://github.com/extrawurst/gitui#diagnostics

[dmytro-tolkodubov]

Ah, thanks! This is what i see there:

tail $HOME/Library/Caches/gitui/gitui.log
10:48:45 [TRACE] (1) gitui::app: [src/app.rs:278] update
10:48:45 [TRACE] (1) asyncgit::diff: [asyncgit/src/diff.rs:93] request
10:48:45 [TRACE] (1) asyncgit::status: [asyncgit/src/status.rs:95] request: [hash: 14046281010676946994] (type: WorkingDir, untracked: true)
10:48:45 [TRACE] (1) asyncgit::status: [asyncgit/src/status.rs:95] request: [hash: 6842313692465843766] (type: Stage, untracked: true)
10:48:45 [TRACE] (3) asyncgit::status: [asyncgit/src/status.rs:152] status fetched: 14046281010676946994 (type: WorkingDir, untracked: true)
10:48:45 [TRACE] (5) asyncgit::status: [asyncgit/src/status.rs:152] status fetched: 6842313692465843766 (type: Stage, untracked: true)
10:48:45 [TRACE] (1) gitui::app: [src/app.rs:295] update_git: Diff
10:48:45 [TRACE] (1) gitui::app: [src/app.rs:295] update_git: Status
10:48:45 [TRACE] (1) gitui::app: [src/app.rs:295] update_git: Status
10:48:46 [TRACE] (1) gitui::app: [src/app.rs:212] event: Input(Key(KeyEvent { code: Char('c'), modifiers: CONTROL }))

[extrawurst]

you did not try to push in that session

[dmytro-tolkodubov]

i think i did, here is the error line (did not paste the whole log, it is a bit bigger)

10:48:35 [TRACE] (1) gitui::app: [src/app.rs:278] update
10:48:35 [TRACE] (1) asyncgit::diff: [asyncgit/src/diff.rs:93] request
10:48:35 [TRACE] (1) asyncgit::status: [asyncgit/src/status.rs:95] request: [hash: 8133653752159640044] (type: WorkingDir, untracked: true)
10:48:35 [TRACE] (1) asyncgit::status: [asyncgit/src/status.rs:95] request: [hash: 16630248863231777639] (type: Stage, untracked: true)
10:48:35 [TRACE] (2) asyncgit::status: [asyncgit/src/status.rs:152] status fetched: 16630248863231777639 (type: Stage, untracked: true)
10:48:35 [TRACE] (5) asyncgit::status: [asyncgit/src/status.rs:152] status fetched: 8133653752159640044 (type: WorkingDir, untracked: true)
10:48:35 [TRACE] (1) gitui::app: [src/app.rs:295] update_git: Diff
10:48:35 [TRACE] (1) gitui::app: [src/app.rs:295] update_git: Status
10:48:35 [TRACE] (1) gitui::app: [src/app.rs:295] update_git: Status
10:48:39 [DEBUG] (7) asyncgit::sync::remotes: creds: 'git@github.com:***/pipeline-base.git' Some("git") (SSH_KEY | SSH_MEMORY | SSH_CUSTOM)
10:48:40 [DEBUG] (7) asyncgit::sync::remotes: creds: 'git@github.com:***/pipeline-base.git' Some("git") (SSH_KEY | SSH_MEMORY | SSH_CUSTOM)
10:48:40 [INFO] push progress: Some(PushProgress { state: Pushing, progress: 100 })
10:48:40 [TRACE] (1) gitui::app: [src/app.rs:295] update_git: Push
10:48:40 [ERROR] push error: git error:Bad credentials.

[extrawurst]

Ok I have no idea what's happening there.
Maybe @jamesb93 can check the config and log, too.

[dmytro-tolkodubov]

Thanks for the great tool though!