Skip to content

Commit 65d6670

Browse files
authored
Replace watches with waits in README (#87)
- Replaced manual `kubectl get ... -w` commands in step 3 with `kubectl wait` for the PVC to improve usability. The manual watches did not terminate automatically, causing confusion about when the deployment step was complete. - `kubectl rollout status` commands are retained as they appropriately block until the deployments are ready. - The pod watch was removed as it was redundant with the rollout status checks.
1 parent c47884d commit 65d6670

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

k8s/deploy/text-to-sql-gke/README.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,17 +106,13 @@ gcloud container clusters get-credentials "${CLUSTER}" --location="${REGION}"
106106
kubectl apply -k k8s/deploy/text-to-sql-gke
107107
```
108108

109-
Watch the PVC and pods:
109+
Wait for the shared storage (PVC) to be bound:
110110

111111
```bash
112-
kubectl get pvc open-rl-shared-pvc -w
112+
kubectl wait --for=jsonpath='{.status.phase}'=Bound pvc/open-rl-shared-pvc --timeout=5m
113113
```
114114

115-
```bash
116-
kubectl get pods -l app.kubernetes.io/part-of=text-to-sql -w
117-
```
118-
119-
Wait for the deployments:
115+
Wait for the deployments to become ready:
120116

121117
```bash
122118
kubectl rollout status deploy/redis-store

0 commit comments

Comments
 (0)