Skip to content

feat: agent registry auth #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kosmoz
Copy link
Member

@kosmoz kosmoz commented Apr 4, 2025

No description provided.

Signed-off-by: Jakob Steiner <[email protected]>
@kosmoz kosmoz force-pushed the kosmoz/gk-598-agents-should-be-able-to-log-in-to-artifact-registry-without branch from 5fce4a7 to b017cb7 Compare April 4, 2025 13:21
@kosmoz kosmoz marked this pull request as ready for review April 10, 2025 10:27
@kosmoz kosmoz requested a review from christophenne April 10, 2025 11:34
Signed-off-by: Jakob Steiner <[email protected]>
Copy link
Member

@christophenne christophenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, left some comments. I tested the docker agent and it works fine, but I am having trouble testing the kubernetes one in a local environment with minikube and no https (even with the alleged fix that I commented).

@kosmoz
Copy link
Member Author

kosmoz commented Apr 14, 2025

Nice work, left some comments. I tested the docker agent and it works fine, but I am having trouble testing the kubernetes one in a local environment with minikube and no https (even with the alleged fix that I commented).

Can you please try again? It worked for me with the following config:

DISTR_HOST="http://host.minikube.internal:8080"
REGISTRY_HOST="host.minikube.internal:8585"
REGISTRY_S3_ENDPOINT="http://host.minikube.internal:9000"

(and hardcoding DISTR_REGISTRY_PLAIN_HTTP: "true" in the kubernetes agent mainfest template)

@kosmoz kosmoz requested a review from christophenne April 14, 2025 09:38
Copy link
Member

@christophenne christophenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works now 👍

my testing issue was an incorrect values.yaml of my helm chart (deployed podinfo and did not enable serviceAccount / set serviceAccount.imagePullSecrets: [])

@christophenne christophenne merged commit e55005a into main Apr 14, 2025
10 checks passed
@christophenne christophenne deleted the kosmoz/gk-598-agents-should-be-able-to-log-in-to-artifact-registry-without branch April 14, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants