-
Notifications
You must be signed in to change notification settings - Fork 18
feat: agent registry auth #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: agent registry auth #747
Conversation
Signed-off-by: Jakob Steiner <[email protected]>
5fce4a7
to
b017cb7
Compare
…should-be-able-to-log-in-to-artifact-registry-without
Signed-off-by: Jakob Steiner <[email protected]>
…should-be-able-to-log-in-to-artifact-registry-without
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
…should-be-able-to-log-in-to-artifact-registry-without
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
Signed-off-by: Jakob Steiner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, left some comments. I tested the docker agent and it works fine, but I am having trouble testing the kubernetes one in a local environment with minikube and no https (even with the alleged fix that I commented).
…should-be-able-to-log-in-to-artifact-registry-without
Can you please try again? It worked for me with the following config: DISTR_HOST="http://host.minikube.internal:8080"
REGISTRY_HOST="host.minikube.internal:8585"
REGISTRY_S3_ENDPOINT="http://host.minikube.internal:9000" (and hardcoding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works now 👍
my testing issue was an incorrect values.yaml of my helm chart (deployed podinfo and did not enable serviceAccount
/ set serviceAccount.imagePullSecrets: []
)
No description provided.