clippy!!

Author: giacomocavalieri

compiler-core/src/erlang.rs

@@ -314,7 +314,7 @@ impl<'a> Generator<'a> {
             // In that case all type variables are phantom type variables!
             ([], _) if let Some((module, type_name, _)) = external_erlang => {
                 let type_ =
-                    builder.start_remote_named_type(ErlangModuleName::new(&module), type_name);
+                    builder.start_remote_named_type(ErlangModuleName::new(module), type_name);
                 for type_variable in phantom_type_variables {
                     builder.type_variable(&type_variable);
                 }
@@ -637,7 +637,7 @@ impl<'a, 'generator> FunctionGenerator<'a, 'generator> {
                 let open_function =
                     builder.start_function(&function_name, arity, arguments.clone());
                 let call = builder
-                    .start_remote_call(ErlangModuleName::new(&module), external_function_name);
+                    .start_remote_call(ErlangModuleName::new(module), external_function_name);
                 for argument in arguments {
                     builder.variable(&argument);
                 }
@@ -957,14 +957,14 @@ impl<'a, 'generator> FunctionGenerator<'a, 'generator> {
                 ..
             } => match type_::collapse_links(type_.clone()).as_ref() {
                 Type::Fn { arguments, .. } => builder.function_reference(
-                    Some(ErlangModuleName::new(&module)),
+                    Some(ErlangModuleName::new(module)),
                     escape_erlang_existing_name(name),
                     arguments.len(),
                 ),
 
                 Type::Named { .. } | Type::Var { .. } | Type::Tuple { .. } => {
                     let name = escape_erlang_existing_name(name);
-                    let call = builder.start_remote_call(ErlangModuleName::new(&module), name);
+                    let call = builder.start_remote_call(ErlangModuleName::new(module), name);
                     builder.end_call(call);
                 }
             },
@@ -1962,7 +1962,7 @@ impl<'a, 'generator> FunctionGenerator<'a, 'generator> {
                 if *module == self.module_generator.module.name {
                     builder.function_reference(None, name, *arity)
                 } else {
-                    builder.function_reference(Some(ErlangModuleName::new(&module)), name, *arity)
+                    builder.function_reference(Some(ErlangModuleName::new(module)), name, *arity)
                 }
             }
 
@@ -1978,7 +1978,7 @@ impl<'a, 'generator> FunctionGenerator<'a, 'generator> {
                 name,
                 ..
             } => builder.function_reference(
-                Some(ErlangModuleName::new(&module)),
+                Some(ErlangModuleName::new(module)),
                 escape_erlang_existing_name(name),
                 *arity,
             ),
@@ -2001,7 +2001,7 @@ impl<'a, 'generator> FunctionGenerator<'a, 'generator> {
             FunctionCall::Call { module, name } => {
                 let call = if module != self.module_generator.module.name {
                     builder.start_remote_call(
-                        ErlangModuleName::new(&module),
+                        ErlangModuleName::new(module),
                         escape_erlang_existing_name(name),
                     )
                 } else {
@@ -2056,7 +2056,7 @@ impl<'a, 'generator> FunctionGenerator<'a, 'generator> {
             FunctionCall::Call { module, name } => {
                 let call = if module != self.module_generator.module.name {
                     builder.start_remote_call(
-                        ErlangModuleName::new(&module),
+                        ErlangModuleName::new(module),
                         escape_erlang_existing_name(name),
                     )
                 } else {

erlang-generation/src/lib.rs

@@ -2647,7 +2647,7 @@ impl ErlangSourceBuilder {
             }
             // We were expecting an expression and someone generated it, we can
             // now pop this off the stack.
-            ErlangSourceBuilderPosition::UnaryOperator { .. } => {
+            ErlangSourceBuilderPosition::UnaryOperator => {
                 self.position.pop();
             }
 
@@ -2766,7 +2766,7 @@ impl ErlangSourceBuilder {
             | ErlangSourceBuilderPosition::FunctionStatement { .. }
             | ErlangSourceBuilderPosition::AnonymousFunctionStatement { .. }
             | ErlangSourceBuilderPosition::DocAttribute
-            | ErlangSourceBuilderPosition::UnaryOperator { .. }
+            | ErlangSourceBuilderPosition::UnaryOperator
             | ErlangSourceBuilderPosition::Case { .. }
             | ErlangSourceBuilderPosition::BinaryOperator { .. }
             | ErlangSourceBuilderPosition::CaseClause { .. }
@@ -2888,7 +2888,7 @@ impl ErlangSourceBuilder {
                     },
                 ..
             }
-            | ErlangSourceBuilderPosition::UnaryOperator { .. }
+            | ErlangSourceBuilderPosition::UnaryOperator
             | ErlangSourceBuilderPosition::BinaryOperator { .. }
             | ErlangSourceBuilderPosition::Case { .. }
             | ErlangSourceBuilderPosition::Map { .. }
@@ -3069,7 +3069,7 @@ impl ErlangSourceBuilder {
             ErlangSourceBuilderPosition::MapField { .. }
             | ErlangSourceBuilderPosition::RecordField { .. }
             | ErlangSourceBuilderPosition::MatchPattern { .. }
-            | ErlangSourceBuilderPosition::UnaryOperator { .. }
+            | ErlangSourceBuilderPosition::UnaryOperator
             | ErlangSourceBuilderPosition::List { .. }
             | ErlangSourceBuilderPosition::BinaryOperator { .. }
             | ErlangSourceBuilderPosition::MatchOperator { .. }
@@ -3136,7 +3136,7 @@ impl ErlangSourceBuilder {
             | ErlangSourceBuilderPosition::FunctionStatement { .. }
             | ErlangSourceBuilderPosition::AnonymousFunctionStatement { .. }
             | ErlangSourceBuilderPosition::List { .. }
-            | ErlangSourceBuilderPosition::UnaryOperator { .. }
+            | ErlangSourceBuilderPosition::UnaryOperator
             | ErlangSourceBuilderPosition::Tuple { .. }
             | ErlangSourceBuilderPosition::TuplePattern { .. }
             | ErlangSourceBuilderPosition::BitArray { .. }
@@ -3427,7 +3427,7 @@ impl ErlangSourceBuilder {
             | ErlangSourceBuilderPosition::BitArray { .. }
             | ErlangSourceBuilderPosition::Map { .. }
             | ErlangSourceBuilderPosition::Block { .. }
-            | ErlangSourceBuilderPosition::UnaryOperator { .. }
+            | ErlangSourceBuilderPosition::UnaryOperator
             | ErlangSourceBuilderPosition::FunctionType {
                 expected:
                     ExpectedFunctionTypeItem::Arguments { .. } | ExpectedFunctionTypeItem::ReturnType,