Skip to content

Commit 5764e25

Browse files
committed
clean for all targets and modes and simplify code
1 parent 5ff1539 commit 5764e25

1 file changed

Lines changed: 10 additions & 12 deletions

File tree

compiler-cli/src/dependencies.rs

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -304,18 +304,16 @@ pub fn cleanup<Telem: Telemetry>(paths: &ProjectPaths, telemetry: Telem) -> Resu
304304
let changes = PackageChanges::between_manifests(&old_manifest, &manifest);
305305
telemetry.resolved_package_versions(&changes);
306306

307-
// Invalidate build caches after removing package
308-
let target = config.target;
309-
let name = config.name.clone();
310-
311-
// We need to clean build directory for the top level package for both dev
312-
// and prod modes
313-
for mode in [Mode::Dev, Mode::Prod] {
314-
let lock = BuildLock::new_target(paths, mode, target)?;
315-
let _guard = lock.lock(&telemetry)?;
316-
317-
let build_directory_path = paths.build_directory_for_package(mode, target, &name);
318-
fs::delete_directory(build_directory_path.as_ref())?;
307+
// We need to clean build directory for the top level package for all modes
308+
for mode in Mode::iter() {
309+
for target in Target::iter() {
310+
let lock = BuildLock::new_target(paths, mode, target)?;
311+
let _guard = lock.lock(&telemetry)?;
312+
313+
let build_directory_path =
314+
paths.build_directory_for_package(mode, target, &config.name);
315+
fs::delete_directory(build_directory_path.as_ref())?;
316+
}
319317
}
320318

321319
Ok(manifest)

0 commit comments

Comments
 (0)