feat(analyse): add back the warning on re-exports

Author: arielherself

compiler-core/src/analyse.rs

@@ -247,40 +247,7 @@ impl<'a, A> ModuleAnalyzer<'a, A> {
             self.register_type_alias(t, &mut env);
         }
 
-        for c in &statements.constants {
-            // don't warn if the definition is a re-export.
-            if let Constant::<(), ()>::Var {
-                location: _,
-                module: _,
-                name,
-                constructor: _,
-                type_: _,
-            } = &*c.value
-            {
-                if name == &c.name {
-                    continue;
-                }
-            }
-
-            if env.unqualified_imported_names.contains_key(&c.name) {
-                self.problems
-                    .warning(Warning::TopLevelDefinitionShadowsImport {
-                        location: c.location,
-                        name: c.name.clone(),
-                    })
-            }
-        }
-
         for f in &statements.functions {
-            let (_name_location, name) = f.name.clone().expect("A module's function must be named");
-            if env.unqualified_imported_names.contains_key(&name) {
-                self.problems
-                    .warning(Warning::TopLevelDefinitionShadowsImport {
-                        location: f.location,
-                        name,
-                    });
-            }
-
             if let Err(error) = self.register_value_from_function(f, &mut env) {
                 return self.all_errors(error);
             }
@@ -428,6 +395,14 @@ impl<'a, A> ModuleAnalyzer<'a, A> {
         } = c;
         self.check_name_case(name_location, &name, Named::Constant);
 
+        if environment.unqualified_imported_names.contains_key(&name) {
+            self.problems
+                .warning(Warning::TopLevelDefinitionShadowsImport {
+                    location: c.location,
+                    name: name.clone(),
+                })
+        }
+
         environment.references.begin_constant();
 
         let definition = FunctionDefinition {
@@ -1457,6 +1432,14 @@ impl<'a, A> ModuleAnalyzer<'a, A> {
 
         self.check_name_case(*name_location, name, Named::Function);
 
+        if environment.unqualified_imported_names.contains_key(name) {
+            self.problems
+                .warning(Warning::TopLevelDefinitionShadowsImport {
+                    location: f.location,
+                    name: name.clone(),
+                });
+        }
+
         environment.references.register_value(
             name.clone(),
             EntityKind::Function,

compiler-core/src/type_/tests/dead_code_detection.rs

@@ -445,7 +445,7 @@ pub const wibble = 2
 
 #[test]
 fn used_shadowed_imported_value() {
-    assert_no_warnings!(
+    assert_warning!(
         (
             "thepackage",
             "wibble",

compiler-core/src/type_/tests/snapshots/gleam_core__type___tests__dead_code_detection__used_shadowed_imported_value.snap

@@ -22,5 +22,4 @@ warning: Definition of "wibble" shadows an imported value
 4 │ pub const wibble = wibble
   │ ^^^^^^^^^^^^^^^^
 
-The imported value could not be used anyway.
-Hint: You could remove the imported value.
+The imported value could not be used in functions anyway.

compiler-core/src/type_/tests/snapshots/gleam_core__type___tests__warnings__unused_alias_warning_test.snap

@@ -22,3 +22,12 @@ warning: Unused imported module alias
 Hint: You can safely remove it.
 
     import gleam/wibble as _
+
+
+warning: Definition of "one" shadows an imported value
+  ┌─ /src/warning/wrn.gleam:3:13
+  │
+3 │             pub const one = one
+  │             ^^^^^^^^^^^^^
+
+The imported value could not be used in functions anyway.