clean for all targets and modes and simplify code

Author: ankddev

compiler-cli/src/dependencies.rs

@@ -299,18 +299,23 @@ pub fn cleanup<Telem: Telemetry>(paths: &ProjectPaths, telemetry: Telem) -> Resu
     let changes = PackageChanges::between_manifests(&old_manifest, &manifest);
     telemetry.resolved_package_versions(&changes);
 
-    // Invalidate build caches after removing package
-    let target = config.target;
-    let name = config.name.clone();
-
-    // We need to clean build directory for the top level package for both dev
-    // and prod modes
-    for mode in [Mode::Dev, Mode::Prod] {
-        let lock = BuildLock::new_target(paths, mode, target)?;
-        let _guard = lock.lock(&telemetry)?;
-
-        let build_directory_path = paths.build_directory_for_package(mode, target, &name);
-        fs::delete_directory(build_directory_path.as_ref())?;
+    // Cleanup build cache of the root package if there are some changes.
+    // Without this, if a removed dependency is still used, teh build will
+    // succeed, resulting in runtime crash due to missing files.
+    if changes.any_changes() {
+        tracing::debug!("cleaning_root_package_build_cache");
+        for mode in Mode::iter() {
+            for target in Target::iter() {
+                let lock = BuildLock::new_target(paths, mode, target)?;
+                let _guard = lock.lock(&telemetry)?;
+
+                let build_directory_path =
+                    paths.build_directory_for_package(mode, target, &config.name);
+                if build_directory_path.exists() {
+                    fs::delete_directory(build_directory_path.as_ref())?;
+                }
+            }
+        }
     }
 
     Ok(manifest)