fix(analyse): do not emit warning for re-exports

Author: arielherself

compiler-core/src/analyse.rs

@@ -7,7 +7,7 @@ mod tests;
 use crate::{
     GLEAM_CORE_PACKAGE_NAME,
     ast::{
-        self, Arg, BitArrayOption, CustomType, Definition, DefinitionLocation, Function,
+        self, Arg, BitArrayOption, Constant, CustomType, Definition, DefinitionLocation, Function,
         GroupedStatements, Import, ModuleConstant, Publicity, RecordConstructor,
         RecordConstructorArg, SrcSpan, Statement, TypeAlias, TypeAst, TypeAstConstructor,
         TypeAstFn, TypeAstHole, TypeAstTuple, TypeAstVar, TypedDefinition, TypedExpr,
@@ -248,6 +248,20 @@ impl<'a, A> ModuleAnalyzer<'a, A> {
         }
 
         for c in &statements.constants {
+            // don't warn if the definition is a re-export.
+            if let Constant::<(), ()>::Var {
+                location: _,
+                module: _,
+                name,
+                constructor: _,
+                type_: _,
+            } = &*c.value
+            {
+                if name == &c.name {
+                    continue;
+                }
+            }
+
             if env.unqualified_imported_names.contains_key(&c.name) {
                 self.problems
                     .warning(Warning::TopLevelDefinitionShadowsImport {

compiler-core/src/type_/tests/dead_code_detection.rs

@@ -445,7 +445,7 @@ pub const wibble = 2
 
 #[test]
 fn used_shadowed_imported_value() {
-    assert_warning!(
+    assert_no_warnings!(
         (
             "thepackage",
             "wibble",

compiler-core/src/type_/tests/snapshots/gleam_core__type___tests__warnings__unused_alias_warning_test.snap

@@ -22,13 +22,3 @@ warning: Unused imported module alias
 Hint: You can safely remove it.
 
     import gleam/wibble as _
-
-
-warning: Definition of "one" shadows an imported value
-  ┌─ /src/warning/wrn.gleam:3:13
-  │
-3 │             pub const one = one
-  │             ^^^^^^^^^^^^^
-
-The imported value could not be used anyway.
-Hint: You could remove the imported value.