Fix erlang-shipment including dev dependencies

The `gleam export erlang-shipment` command was incorrectly including dev
dependencies in the exported shipment.

The fix filters dev dependencies at compile time in ProjectCompiler.
When building in Prod mode, only transitive production dependencies are
compiled, so dev packages never appear in the build output.

Closes #5308

Author: jtdowney

CHANGELOG.md

@@ -315,6 +315,10 @@
   when emitting TypeScript declarations.
   ([Surya Rose](https://github.com/GearsDatapacks))
 
+- Fixed a bug where dev dependencies would be compiled and included in
+  production builds such as `gleam export erlang-shipment`.
+  ([John Downey](https://github.com/jtdowney))
+
 - Fixed a bug where the package cache would not properly be reset when a version
   of a package was replaced on Hex.
   ([Surya Rose](https://github.com/GearsDatapacks))

compiler-core/src/build/project_compiler.rs

@@ -180,11 +180,31 @@ where
         self.defined_modules.clear();
     }
 
+    fn retain_only_production_packages(&mut self) {
+        let mut production = HashSet::new();
+        let mut queue: Vec<_> = self.config.dependencies.keys().cloned().collect();
+        while let Some(name) = queue.pop() {
+            if production.insert(name.clone())
+                && let Some(pkg) = self.packages.get(name.as_str())
+            {
+                queue.extend(pkg.requirements.iter().cloned());
+            }
+        }
+        self.packages
+            .retain(|name, _| production.contains(name.as_str()));
+    }
+
     /// Compiles all packages in the project and returns the compiled
     /// information from the root package
     pub fn compile(mut self) -> Result<Built> {
         self.reset_state_for_new_compile_run();
 
+        // In production mode, skip dev-only dependencies entirely so they
+        // are never compiled.
+        if self.mode() == Mode::Prod {
+            self.retain_only_production_packages();
+        }
+
         // Each package may specify a Gleam version that it supports, so we
         // verify that this version is appropriate.
         self.check_gleam_version()?;

test/erlang_shipment_no_dev_deps/.gitignore

@@ -0,0 +1,4 @@
+*.beam
+*.ez
+/build
+erl_crash.dump

test/erlang_shipment_no_dev_deps/gleam.toml

@@ -0,0 +1,11 @@
+name = "shipment_test"
+version = "0.1.0"
+
+[dependencies]
+gleam_stdlib = "~> 0.34"
+# hpack_erl has otp_app = "hpack" (different from package name)
+# This tests that packages with different OTP app names are included correctly
+hpack_erl = "~> 0.3"
+
+[dev_dependencies]
+gleeunit = "~> 1.0"

test/erlang_shipment_no_dev_deps/manifest.toml

@@ -0,0 +1,13 @@
+# This file was generated by Gleam
+# You typically do not need to edit this file
+
+packages = [
+  { name = "gleam_stdlib", version = "0.68.1", build_tools = ["gleam"], requirements = [], otp_app = "gleam_stdlib", source = "hex", outer_checksum = "F7FAEBD8EF260664E86A46C8DBA23508D1D11BB3BCC6EE1B89B3BC3E5C83FF1E" },
+  { name = "gleeunit", version = "1.9.0", build_tools = ["gleam"], requirements = ["gleam_stdlib"], otp_app = "gleeunit", source = "hex", outer_checksum = "DA9553CE58B67924B3C631F96FE3370C49EB6D6DC6B384EC4862CC4AAA718F3C" },
+  { name = "hpack_erl", version = "0.3.0", build_tools = ["rebar3"], requirements = [], otp_app = "hpack", source = "hex", outer_checksum = "D6137D7079169D8C485C6962DFE261AF5B9EF60FBC557344511C1E65E3D95FB0" },
+]
+
+[requirements]
+gleam_stdlib = { version = "~> 0.34" }
+gleeunit = { version = "~> 1.0" }
+hpack_erl = { version = "~> 0.3" }

test/erlang_shipment_no_dev_deps/src/shipment_test.gleam

@@ -0,0 +1,5 @@
+import gleam/io
+
+pub fn main() {
+  io.println("Hello from shipment test!")
+}

test/erlang_shipment_no_dev_deps/test.sh

@@ -0,0 +1,49 @@
+#!/bin/sh
+
+set -eu
+
+GLEAM_COMMAND=${GLEAM_COMMAND:-"cargo run --quiet --"}
+
+g() {
+  echo "Running: $GLEAM_COMMAND $@"
+  $GLEAM_COMMAND "$@"
+}
+
+echo Resetting the build directory to get to a known state
+rm -fr build
+
+echo Building erlang shipment
+g export erlang-shipment
+
+echo Checking that gleam_stdlib IS in the shipment
+if [ ! -d "build/erlang-shipment/gleam_stdlib" ]; then
+  echo "ERROR: gleam_stdlib should be in the shipment but was not found"
+  exit 1
+fi
+echo "gleam_stdlib found in shipment"
+
+echo Checking that hpack IS in the shipment
+echo "(hpack_erl package has otp_app=hpack, so directory is named hpack)"
+if [ ! -d "build/erlang-shipment/hpack" ]; then
+  echo "ERROR: hpack (from hpack_erl package) should be in the shipment but was not found"
+  exit 1
+fi
+echo "hpack found in shipment"
+
+echo Checking that gleeunit is NOT in the shipment
+if [ -d "build/erlang-shipment/gleeunit" ]; then
+  echo "ERROR: gleeunit is a dev dependency and should NOT be in the shipment"
+  exit 1
+fi
+echo "gleeunit correctly excluded from shipment"
+
+echo Checking that the root package IS in the shipment
+if [ ! -d "build/erlang-shipment/shipment_test" ]; then
+  echo "ERROR: shipment_test (root package) should be in the shipment but was not found"
+  exit 1
+fi
+echo "shipment_test found in shipment"
+
+echo
+echo Success!
+echo