Skip to content

Commit f6d38e1

Browse files
committed
test(commissioning): log full CommissionableFilter on discovery failure
Addresses Gemini review (project-chip#455): the no-devices-found warning printed only filter.discriminator; now logs the entire CommissionableFilter so vendor/ product/other criteria are visible when discovery fails.
1 parent 86dc302 commit f6d38e1

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

rs-matter/tests/commissioning.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -358,10 +358,7 @@ async fn discover_device<const A: usize>(
358358
.map_err(|_| Error::from(rs_matter::error::ErrorCode::Failure))??;
359359

360360
devices.into_iter().next().ok_or_else(|| {
361-
warn!(
362-
"No devices found matching discriminator {:?}",
363-
filter.discriminator
364-
);
361+
warn!("No devices found matching filter {:?}", filter);
365362
rs_matter::error::ErrorCode::NotFound.into()
366363
})
367364
}
@@ -421,10 +418,7 @@ async fn discover_device<const A: usize>(
421418
.await?;
422419

423420
devices.into_iter().next().ok_or_else(|| {
424-
warn!(
425-
"No devices found matching discriminator {:#?}",
426-
filter.discriminator
427-
);
421+
warn!("No devices found matching filter {:#?}", filter);
428422
rs_matter::error::ErrorCode::NotFound.into()
429423
})
430424
}

0 commit comments

Comments
 (0)