Skip to content

Commit 5c94e18

Browse files
authored
Merge pull request #1469 from gliderlabs/drop-heroku-20
chore: drop support for heroku-20
2 parents 9bd1d9e + 5decde4 commit 5c94e18

File tree

6 files changed

+6
-15
lines changed

6 files changed

+6
-15
lines changed

Diff for: .github/workflows/main.yml

-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ jobs:
2525
- "true"
2626
- "false"
2727
heroku:
28-
- 20
2928
- 22
3029
- 24
3130

@@ -112,7 +111,6 @@ jobs:
112111
- buildpack-scala
113112
- buildpack-static
114113
heroku:
115-
- 20
116114
- 22
117115
- 24
118116

Diff for: .github/workflows/release.yml

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ jobs:
1515
fail-fast: false
1616
matrix:
1717
heroku:
18-
- 20
1918
- 22
2019
- 24
2120

Diff for: Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# syntax=docker/dockerfile:1
2-
ARG STACK_VERSION=20
2+
ARG STACK_VERSION=22
33

44
FROM golang:1.24 AS builder
55
RUN mkdir /src
@@ -10,7 +10,7 @@ ARG VERSION
1010
RUN go build -a -ldflags "-X main.Version=$VERSION" -o herokuish .
1111

1212
FROM ubuntu:${STACK_VERSION}.04 AS base
13-
ARG STACK_VERSION=20
13+
ARG STACK_VERSION=22
1414
ARG TARGETARCH
1515

1616
ADD https://raw.githubusercontent.com/heroku/stack-images/main/heroku-${STACK_VERSION}/setup.sh /tmp/setup-01.sh

Diff for: Makefile

+1-7
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ SHELL := /bin/bash
1414
SYSTEM := $(shell sh -c 'uname -s 2>/dev/null')
1515
DOCKER_ARGS ?= "--pull"
1616
BUILDX ?= true
17-
STACK_VERSION ?= 20
17+
STACK_VERSION ?= 22
1818

1919
shellcheck:
2020
ifneq ($(shell shellcheck --version > /dev/null 2>&1 ; echo $$?),0)
@@ -55,17 +55,12 @@ build: bindata.go
5555
$(MAKE) build/deb/$(NAME)_$(VERSION)_all.deb
5656

5757
build/docker:
58-
$(MAKE) build/docker/20 STACK_VERSION=20
5958
$(MAKE) build/docker/22 STACK_VERSION=22
6059
$(MAKE) build/docker/24 STACK_VERSION=24
6160

6261
build/docker/$(STACK_VERSION): bindata.go
6362
ifeq ($(BUILDX),true)
64-
ifeq ($(STACK_VERSION),20)
65-
docker buildx build --no-cache ${DOCKER_ARGS} --pull --progress plain --platform linux/arm64/v8,linux/amd64 --build-arg STACK_VERSION=$(STACK_VERSION) --build-arg VERSION=$(VERSION) -t $(IMAGE_NAME):$(BUILD_TAG)-$(STACK_VERSION) -t $(IMAGE_NAME):latest-$(STACK_VERSION) -t $(IMAGE_NAME):$(BUILD_TAG) -t $(IMAGE_NAME):latest .
66-
else
6763
docker buildx build --no-cache ${DOCKER_ARGS} --pull --progress plain --platform linux/arm64/v8,linux/amd64 --build-arg STACK_VERSION=$(STACK_VERSION) --build-arg VERSION=$(VERSION) -t $(IMAGE_NAME):$(BUILD_TAG)-$(STACK_VERSION) -t $(IMAGE_NAME):latest-$(STACK_VERSION) .
68-
endif
6964
else
7065
docker build --no-cache ${DOCKER_ARGS} --pull --progress plain --build-arg STACK_VERSION=$(STACK_VERSION) --build-arg VERSION=$(VERSION) -t $(IMAGE_NAME):$(BUILD_TAG)-$(STACK_VERSION) -t $(IMAGE_NAME):latest-$(STACK_VERSION) -t $(IMAGE_NAME):$(BUILD_TAG) .
7166
endif
@@ -127,7 +122,6 @@ clean:
127122
docker rmi herokuish:dev || true
128123

129124
deps: bindata.go
130-
docker pull heroku/heroku:20-build
131125
docker pull heroku/heroku:22-build
132126
docker pull heroku/heroku:24-build
133127
cd / && go get -u github.com/progrium/basht/...

Diff for: README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ A command line tool for emulating Heroku build and runtime tasks in containers.
88

99
Herokuish is made for platform authors. The project consolidates and decouples Heroku compatibility logic (running buildpacks, parsing Procfile) and supporting workflow (importing/exporting slugs) from specific platform images like those in Dokku/Buildstep, Deis, Flynn, etc.
1010

11-
The goal is to be the definitive, well maintained and heavily tested Heroku emulation utility shared by all. It is based on the [Heroku:20, Heroku:22, and Heroku:24 system images](https://github.com/heroku/stack-images). Together they form a toolkit for achieving Heroku compatibility.
11+
The goal is to be the definitive, well maintained and heavily tested Heroku emulation utility shared by all. It is based on the [Heroku:22, and Heroku:24 system images](https://github.com/heroku/stack-images). Together they form a toolkit for achieving Heroku compatibility.
1212

1313
Herokuish is a community project and is in no way affiliated with Heroku.
1414

@@ -208,7 +208,7 @@ $ docker run --rm -e TRACE=true -v /abs/app/path:/tmp/app gliderlabs/herokuish /
208208
You can also set a custom buildpack:
209209
210210
```shell
211-
docker run -e BUILDPACK_URL="https://github.com/custom/buildpack.git#with-a-branch" -e STACK=heroku-20 -e TRACE=true --rm -v ./:/tmp/app -it gliderlabs/herokuish /bin/herokuish test
211+
docker run -e BUILDPACK_URL="https://github.com/custom/buildpack.git#with-a-branch" -e STACK=heroku-22 -e TRACE=true --rm -v ./:/tmp/app -it gliderlabs/herokuish /bin/herokuish test
212212
```
213213
214214
Note that the underlying buildpacks will not trace their commands with `TRACE=true` is enabled. They need to independently set `set -x` in order to trace execution.

Diff for: include/buildpack.bash

+1-1
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ buildpack-setup() {
158158
# shellcheck disable=SC2154
159159
export HOME="$app_path"
160160
export REQUEST_ID="build-$RANDOM"
161-
export STACK="${STACK:-heroku-20}"
161+
export STACK="${STACK:-heroku-22}"
162162
# build_path defined in outer scope
163163
# shellcheck disable=SC2154
164164
cp -r "$app_path/." "$build_path"

0 commit comments

Comments
 (0)