Skip to content

Commit c1d68b5

Browse files
committed
Merge pull request #38 from michaelshobbs/mh-release-0.3.1
v0.3.1
2 parents 04ef17b + 3ead20e commit c1d68b5

18 files changed

+53
-226
lines changed

CHANGELOG.md

+15
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,21 @@ All notable changes to this project will be documented in this file.
1010

1111
### Changed
1212

13+
## [0.3.1] - 2015-07-09
14+
### Fixed
15+
- Fixed directory permission for custom buildpacks
16+
17+
### Added
18+
- Added ability to build in docker container
19+
20+
### Removed
21+
- Remove testing play-v1 from play buildpack
22+
23+
### Changed
24+
- Build from mainline heroku/cedar:14 docker images
25+
- Bump nodejs/scala buildpack versions
26+
27+
1328
## [0.3.0] - 2015-04-04
1429
### Fixed
1530
- Fixed Scala buildpack and app test

Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM progrium/cedarish:latest
1+
FROM heroku/cedar:14
22
RUN curl https://github.com/gliderlabs/herokuish/releases/download/v0.3.0/herokuish_0.3.0_linux_x86_64.tgz \
33
--silent -L | tar -xzC /bin
44
RUN /bin/herokuish buildpack install \

Dockerfile.build

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
FROM golang:1.4-cross
2+
RUN curl -s -o - https://get.docker.com/builds/Linux/x86_64/docker-1.6.2 > /usr/local/bin/docker && chmod +x /usr/local/bin/docker

Dockerfile.dev

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM progrium/cedarish:latest
1+
FROM heroku/cedar:14
22
COPY ./build/linux/herokuish /bin/herokuish
33
RUN /bin/herokuish buildpack install \
44
&& ln -s /bin/herokuish /build \

Makefile

+19-8
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,30 @@
1-
NAME=herokuish
2-
HARDWARE=$(shell uname -m)
3-
VERSION=0.3.0
1+
NAME = herokuish
2+
HARDWARE = $(shell uname -m)
3+
VERSION ?= 0.3.1
4+
IMAGE_NAME ?= $(NAME)
5+
BUILD_TAG ?= dev
46

57
build:
68
cat buildpacks/*/buildpack* | sed 'N;s/\n/ /' > include/buildpacks.txt
79
go-bindata include
810
mkdir -p build/linux && GOOS=linux go build -ldflags "-X main.Version $(VERSION)" -o build/linux/$(NAME)
911
mkdir -p build/darwin && GOOS=darwin go build -ldflags "-X main.Version $(VERSION)" -o build/darwin/$(NAME)
1012
ifeq ($(CIRCLECI),true)
11-
docker build -t $(NAME):dev .
13+
docker build -t $(IMAGE_NAME):$(BUILD_TAG) .
1214
else
13-
docker build -f Dockerfile.dev -t $(NAME):dev .
15+
docker build -f Dockerfile.dev -t $(IMAGE_NAME):$(BUILD_TAG) .
1416
endif
1517

18+
build-in-docker:
19+
docker build -f Dockerfile.build -t $(NAME)-build .
20+
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock \
21+
-v ${PWD}:/usr/src/myapp -w /usr/src/myapp \
22+
-e IMAGE_NAME=$(IMAGE_NAME) -e BUILD_TAG=$(BUILD_TAG) -e VERSION=master \
23+
$(NAME)-build make -e deps build
24+
docker rmi $(NAME)-build || true
25+
1626
deps:
17-
docker pull progrium/cedarish:latest
27+
docker pull heroku/cedar:14
1828
go get -u github.com/jteeuwen/go-bindata/...
1929
go get -u github.com/progrium/gh-release/...
2030
go get -u github.com/progrium/basht/...
@@ -25,13 +35,14 @@ test:
2535

2636
circleci:
2737
docker version
28-
rm ~/.gitconfig
38+
rm -f ~/.gitconfig
2939
mv Dockerfile.dev Dockerfile
3040

3141
release: build
3242
rm -rf release && mkdir release
3343
tar -zcf release/$(NAME)_$(VERSION)_linux_$(HARDWARE).tgz -C build/linux $(NAME)
3444
tar -zcf release/$(NAME)_$(VERSION)_darwin_$(HARDWARE).tgz -C build/darwin $(NAME)
35-
gh-release create gliderlabs/$(NAME) $(VERSION) $(shell git rev-parse --abbrev-ref HEAD)
45+
gh-release create gliderlabs/$(NAME) $(VERSION) \
46+
$(shell git rev-parse --abbrev-ref HEAD) v$(VERSION)
3647

3748
.PHONY: build

README.md

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,16 @@
1-
# herokuish [![Circle CI](https://circleci.com/gh/gliderlabs/herokuish.png?style=shield)](https://circleci.com/gh/gliderlabs/herokuish)
1+
# herokuish
2+
3+
[![Circle CI](https://circleci.com/gh/gliderlabs/herokuish.png?style=shield)](https://circleci.com/gh/gliderlabs/herokuish)
4+
[![IRC Channel](https://img.shields.io/badge/irc-%23gliderlabs-blue.svg)](https://kiwiirc.com/client/irc.freenode.net/#gliderlabs)
25

36
A command line tool for emulating Heroku build and runtime tasks in containers.
47

58
Herokuish is made for platform authors. The project consolidates and decouples Heroku compatibility logic (running buildpacks, parsing Procfile) and supporting workflow (importing/exporting slugs) from specific platform images like those in Dokku/Buildstep, Deis, Flynn, etc.
69

710
The goal is to be the definitive, well maintained and heavily tested Heroku emulation utility shared by all. It is complemented by [progrium/cedarish](https://github.com/progrium/cedarish), which focuses on reproducing the base Heroku system image. Together they form a toolkit for achieving Heroku compatibility.
811

12+
Herokuish is a community project and is in no way affiliated with Heroku.
13+
914
## Getting herokuish
1015

1116
Download and uncompress the latest binary tarball from [releases](https://github.com/gliderlabs/herokuish/releases).
@@ -157,6 +162,8 @@ That said, herokuish was designed based on the experience developing and re-deve
157162

158163
In fact, since I hope this is the final implementation of Heroku emulation I'm involved with, I'd like to finally thank Matt Freeman ([@nonuby](https://twitter.com/nonuby)). I've been more or less copy-and-pasting code he originally wrote for the now defunct [OpenRoku](https://github.com/openruko) since 2012.
159164

165+
Lastly, thank you Heroku for pioneering such a great platform and inspiring all of us to try and take it further.
166+
160167
## License
161168

162169
BSD
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v64
1+
v76

buildpacks/buildpack-play/tests/play-v1/Procfile

-1
This file was deleted.

buildpacks/buildpack-play/tests/play-v1/README.md

-96
This file was deleted.

buildpacks/buildpack-play/tests/play-v1/app/controllers/Application.java

-16
This file was deleted.

buildpacks/buildpack-play/tests/play-v1/conf/application.conf

-54
This file was deleted.

buildpacks/buildpack-play/tests/play-v1/conf/dependencies.yml

-4
This file was deleted.

buildpacks/buildpack-play/tests/play-v1/conf/routes

-15
This file was deleted.

buildpacks/buildpack-play/tests/play-v1/test.sh

-2
This file was deleted.

buildpacks/buildpack-play/tests/play-v1/test/Application.test.html

-7
This file was deleted.

buildpacks/buildpack-play/tests/play-v1/test/ApplicationTest.java

-17
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v54
1+
v58

include/buildpack.bash

+5-1
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ buildpack-execute() {
7676

7777
IFS='#' read url commit <<< "$BUILDPACK_URL"
7878
buildpack-install "$url" "$commit" custom &> /dev/null
79+
80+
chown -R "$unprivileged_user:$unprivileged_group" "$buildpack_path/custom"
7981

8082
selected_name="$(unprivileged $selected_path/bin/detect $build_path)"
8183
else
@@ -102,7 +104,9 @@ buildpack-execute() {
102104

103105
cd "$build_path"
104106
unprivileged "$selected_path/bin/compile" "$build_path" "$cache_path" "$env_path"
105-
unprivileged "$selected_path/bin/release" "$build_path" "$cache_path" > "$build_path/.release"
107+
if [[ -f "$selected_path/bin/release" ]]; then
108+
unprivileged "$selected_path/bin/release" "$build_path" "$cache_path" > "$build_path/.release"
109+
fi
106110
cd - > /dev/null
107111

108112
shopt -s dotglob nullglob

0 commit comments

Comments
 (0)