Fix missing parentId and ancestor filters in paginateSubRows

df backend: Sub-group headers were missing parentId in their __state.
Add parentId to sub-group header state when depth > 0.

DuckDB backend: duckdbCollectPageRows only included the current level's
filter when querying leaf sub-rows, missing ancestor filters. For
multi-level groupBy, this returned wrong rows from other groups sharing
the same sub-group value. Thread parentFilters through recursive calls
to accumulate ancestor filter clauses at each level.

Add test assertions for both fixes.

Author: glin

R/backend-df.R

@@ -303,6 +303,9 @@ dfCollectPageRows <- function(groupedDf, flatSizes, pageStart, pageEnd, groupBy,
         grouped = TRUE,
         subRowCount = subRowCount
       )
+      if (!is.null(parentId)) {
+        headerRow[["__state"]]$parentId <- parentId
+      }
       rows <- c(rows, list(headerRow))
     }
 

R/backend-duckdb.R

@@ -465,7 +465,8 @@ duckdbFlatSizes <- function(groupTree, expandedMap, groupBy, depth, parentId) {
 # Collect rows that fall within [pageStart, pageEnd) from the flattened group stream.
 duckdbCollectPageRows <- function(con, groupTree, flatSizes, pageStart, pageEnd,
                                    groupBy, baseWhere, sortBy, columns,
-                                   depth, parentId, expandedMap) {
+                                   depth, parentId, expandedMap,
+                                   parentFilters = list(clauses = character(0), params = list())) {
   groupCol <- groupBy[[depth + 1]]
   isLeafLevel <- depth + 1 >= length(groupBy)
   escapedGroupCol <- duckdbQuoteIdentifier(groupCol)
@@ -528,8 +529,8 @@ duckdbCollectPageRows <- function(con, groupTree, flatSizes, pageStart, pageEnd,
 
         if (subSliceEnd > subSliceStart) {
           childFilters <- list(
-            clauses = paste0(escapedGroupCol, " = ?"),
-            params = list(groupValue)
+            clauses = c(parentFilters$clauses, paste0(escapedGroupCol, " = ?")),
+            params = c(parentFilters$params, list(groupValue))
           )
           subQuery <- buildDuckdbSubRowSql("reactable_data", baseWhere, childFilters, sortBy)
           # Add LIMIT/OFFSET to the sub-row query
@@ -557,11 +558,16 @@ duckdbCollectPageRows <- function(con, groupTree, flatSizes, pageStart, pageEnd,
                                        depth = depth + 1, parentId = groupId)
         childPageStart <- pageStart - (nodeStart + 1L)
         childPageEnd <- pageEnd - (nodeStart + 1L)
+        levelFilters <- list(
+          clauses = c(parentFilters$clauses, paste0(escapedGroupCol, " = ?")),
+          params = c(parentFilters$params, list(groupValue))
+        )
         childRows <- duckdbCollectPageRows(con, childTree, childSizes,
                                             childPageStart, childPageEnd,
                                             groupBy, baseWhere, sortBy, columns,
                                             depth = depth + 1, parentId = groupId,
-                                            expandedMap = expandedMap)
+                                            expandedMap = expandedMap,
+                                            parentFilters = levelFilters)
         if (!is.null(childRows) && nrow(childRows) > 0) {
           rows <- c(rows, list(childRows))
         }

tests/testthat/test-backend-df.R

@@ -897,6 +897,9 @@ test_that("dfPaginateSubRows multi-level with both levels expanded", {
   expect_equal(result$data[["__state"]]$id,
                c("mfr:Acura", "mfr:Acura.type:Small", "0",
                  "mfr:Acura.type:Midsize", "mfr:Audi"))
+  # Sub-group headers have parentId
+  expect_equal(result$data[["__state"]]$parentId[2], "mfr:Acura")
+  expect_equal(result$data[["__state"]]$parentId[4], "mfr:Acura")
   # Leaf sub-row has parentId
   expect_equal(result$data[["__state"]]$parentId[3], "mfr:Acura.type:Small")
   expect_equal(result$data$model[3], "Integra")

tests/testthat/test-backend-duckdb.R

@@ -839,6 +839,10 @@ test_that("backendDuckdb - paginateSubRows multi-level both levels expanded", {
   # Leaf rows should have parentId pointing to their sub-group
   leafRows <- which(!is.na(result$data$`__state`$index))
   expect_true(all(result$data$`__state`$parentId[leafRows] == "mfr:Acura.type:Small"))
+
+  # Leaf rows should only be from Acura's Small group (Integra, Legend), not Audi's
+  leafModels <- sort(result$data$model[leafRows])
+  expect_equal(leafModels, c("Integra", "Legend"))
 })
 
 test_that("backendDuckdb - paginateSubRows multi-level page boundary inside expanded children", {