Skip to content

Commit d61e4c5

Browse files
committed
simplify
1 parent 33a6082 commit d61e4c5

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

lib/support/Chart.ts

+4-9
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,8 @@ export type ChartColor = keyof typeof chartColors | (string & {})
4242
export type KV = { key: string; value: number; color?: ChartColor }
4343

4444
export function getColor(...colors: (ChartColor | string | null | undefined)[]): string {
45-
for (const color of colors) {
46-
if (color != null) {
47-
return chartColors[color as keyof typeof chartColors] || color
48-
}
49-
}
50-
return chartColors.blue
45+
const color = colors.find((color) => color != null)
46+
return chartColors[color as keyof typeof chartColors] || color || chartColors.blue
5147
}
5248

5349
const { gray: _gray, ...rest } = chartColors
@@ -59,11 +55,10 @@ export function scheme<T extends { key: string; color?: ChartColor }>(
5955
): (d: T) => string {
6056
const map = new Map<string, string>()
6157

62-
for (let i = 0; i < data.length; i++) {
63-
const d = data[i]
58+
data.forEach((d, i) => {
6459
const color = getColor(d.color, colors?.[i % (colors?.length ?? 1)])
6560
map.set(d.key, color)
66-
}
61+
})
6762

6863
return (d: T): string => {
6964
return map.get(d.key) ?? unknown

0 commit comments

Comments
 (0)