Skip to content

Commit bfd6006

Browse files
committed
Add a changelog for bugfix #1207
Also, add one more assert to a functional test which would have caught the bug in question.
1 parent b04f128 commit bfd6006

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
### Bugfixes
2+
3+
* Fixed a bug in `globus timer create transfer` which caused the timer name to
4+
be set incorrectly when filter rules are used.

tests/functional/timer/test_transfer_create.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,13 +570,16 @@ def test_timer_creation_supports_filter_rules(run_line, ep_for_timer):
570570
}
571571
for opt in filter_opts
572572
]
573+
name = "Awesome Timer"
573574

574575
run_line(
575576
[
576577
"globus",
577578
"timer",
578579
"create",
579580
"transfer",
581+
"--name",
582+
name,
580583
"--stop-after-runs",
581584
"1",
582585
"--recursive",
@@ -587,5 +590,9 @@ def test_timer_creation_supports_filter_rules(run_line, ep_for_timer):
587590
)
588591

589592
sent_data = json.loads(get_last_request().body)
590-
transfer_body = sent_data["timer"]["body"]
593+
timer_doc = sent_data["timer"]
594+
transfer_body = timer_doc["body"]
595+
596+
# asserting the name is a regression test for #1206
597+
assert timer_doc["name"] == name
591598
assert transfer_body["filter_rules"] == expected_filter_rules

0 commit comments

Comments
 (0)