fix tests - remove useless override

Author: SebSept

.phpstan-baseline.missingType.iterableValue.php

@@ -14863,18 +14863,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/src/Glpi/Form/Destination/CommonITILField/RequesterFieldConfig.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Method Glpi\\\\Form\\\\Destination\\\\CommonITILField\\\\SLAField\\:\\:applyConfiguratedValueToInputUsingAnswers\\(\\) has parameter \\$input with no value type specified in iterable type array\\.$#',
-	'identifier' => 'missingType.iterableValue',
-	'count' => 1,
-	'path' => __DIR__ . '/src/Glpi/Form/Destination/CommonITILField/SLAField.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method Glpi\\\\Form\\\\Destination\\\\CommonITILField\\\\SLAField\\:\\:applyConfiguratedValueToInputUsingAnswers\\(\\) return type has no value type specified in iterable type array\\.$#',
-	'identifier' => 'missingType.iterableValue',
-	'count' => 1,
-	'path' => __DIR__ . '/src/Glpi/Form/Destination/CommonITILField/SLAField.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Method Glpi\\\\Form\\\\Destination\\\\CommonITILField\\\\SLATTOFieldConfig\\:\\:jsonDeserialize\\(\\) has parameter \\$data with no value type specified in iterable type array\\.$#',
 	'identifier' => 'missingType.iterableValue',

.phpstan-baseline.php

@@ -16741,6 +16741,12 @@
 	'count' => 1,
 	'path' => __DIR__ . '/src/NotificationTargetTicket.php',
 ];
+$ignoreErrors[] = [
+	'message' => '#^Parameter \\#2 \\$id of static method Dropdown\\:\\:getDropdownName\\(\\) expects int, float\\|int\\|string given\\.$#',
+	'identifier' => 'argument.type',
+	'count' => 2,
+	'path' => __DIR__ . '/src/NotificationTargetTicket.php',
+];
 $ignoreErrors[] = [
 	'message' => '#^Argument of an invalid type array\\<array\\|string\\>\\|string supplied for foreach, only iterables are supported\\.$#',
 	'identifier' => 'foreach.nonIterable',

src/Glpi/Form/Destination/CommonITILField/SLAField.php

@@ -34,40 +34,4 @@
 
 namespace Glpi\Form\Destination\CommonITILField;
 
-use Glpi\DBAL\JsonFieldInterface;
-use Glpi\Form\AnswersSet;
-use InvalidArgumentException;
-use Override;
-
-abstract class SLAField extends SLMField
-{
-    #[Override]
-    public function applyConfiguratedValueToInputUsingAnswers(
-        JsonFieldInterface $config,
-        array $input,
-        AnswersSet $answers_set
-    ): array {
-        if (!$config instanceof SLMFieldConfig) {
-            throw new InvalidArgumentException("Unexpected config class");
-        }
-
-        // Only one strategy is allowed
-        $strategy = current($config->getStrategies());
-        if ($strategy === false) {
-            return $input;
-        }
-
-        // Compute value according to strategy
-        $slm_id = $strategy->getSLMID($config);
-
-        // Do not edit input if invalid value was found
-        $slm = $this->getSLM();
-        if (!$slm::getById($slm_id)) {
-            return $input;
-        }
-
-        $input[$slm::getFieldNames($this->getType())[1]] = $slm_id;
-
-        return $input;
-    }
-}
+abstract class SLAField extends SLMField {}

tests/functional/Glpi/Form/Destination/CommonITILField/OLATTOFieldTest.php

@@ -239,7 +239,11 @@ private function checkOLATTOFieldConfiguration(
         // Insert config
         $destinations = $form->getDestinations();
         $this->assertCount(1, $destinations);
+        if ($expected_olas_tto_id !== 0 && countElementsInTable(OLA::getTable(), ['id' => $expected_olas_tto_id]) !== 1) {
+            throw new \Exception("Expected OLA TTO with ID $expected_olas_tto_id not found in database. Wrong data preparation.");
+        }
         $destination = current($destinations);
+
         $this->updateItem(
             $destination::getType(),
             $destination->getId(),
@@ -262,8 +266,11 @@ private function checkOLATTOFieldConfiguration(
         $ticket = current($created_items);
 
         // Check ola_id_tto field
-        $ticket_tto_data = $ticket->getOlasTTOData()[0] ?? throw new \Exception('Ola TTO not found');
-        $this->assertEquals($expected_olas_tto_id, $ticket_tto_data['olas_id']);
+        $ticket_tto_id = $expected_olas_tto_id
+            ? ($ticket->getOlasTTOData()[0])['olas_id'] ?? throw new \Exception('Ola TTO not found')
+            : 0
+        ;
+        $this->assertEquals($expected_olas_tto_id, $ticket_tto_id, "The created ticket should have the expected OLA TTO ID");
 
         // Return the created ticket to be able to check other fields
         return $ticket;

tests/functional/RuleTicketTest.php

@@ -1638,8 +1638,6 @@ public function testTaskTemplateDoesNotReopenAClosedTicketWithRule()
      */
     #[TestWith(['field' => 'time_to_resolve'])] // $field is both the rule action field and the ticket field.
     #[TestWith(['field' => 'time_to_own'])]
-    #[TestWith(['field' => 'internal_time_to_resolve'])] // to remove when PR is merged - https://github.com/glpi-project/glpi/pull/19593
-    #[TestWith(['field' => 'internal_time_to_own'])] // to remove when PR is merged - https://github.com/glpi-project/glpi/pull/19593
     public function testDeleteLevelAgreementValuesAction(string $field): void
     {
         $this->login();