Skip to content

Commit 485fccc

Browse files
committed
fix HLAPI exception
1 parent e578405 commit 485fccc

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

src/Glpi/Api/HL/Controller/ITILController.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -450,16 +450,20 @@ public static function getRawKnownSchemas(): array
450450
];
451451
$schemas[$itil_type]['properties']['sla_ttr'] = self::getDropdownTypeSchema(class: SLA::class, field: 'slas_id_ttr', full_schema: 'SLA') + ['x-version-introduced' => '2.1.0'];
452452
$schemas[$itil_type]['properties']['sla_tto'] = self::getDropdownTypeSchema(class: SLA::class, field: 'slas_id_tto', full_schema: 'SLA') + ['x-version-introduced' => '2.1.0'];
453-
$schemas[$itil_type]['properties']['ola_ttr'] = self::getDropdownTypeSchema(class: OLA::class, field: 'olas_id_ttr', full_schema: 'OLA') + ['x-version-introduced' => '2.1.0'];
454-
$schemas[$itil_type]['properties']['ola_tto'] = self::getDropdownTypeSchema(class: OLA::class, field: 'olas_id_tto', full_schema: 'OLA') + ['x-version-introduced' => '2.1.0'];
455453
$schemas[$itil_type]['properties']['sla_level_ttr'] = self::getDropdownTypeSchema(class: SlaLevel::class, field: 'slalevels_id_ttr', full_schema: 'SLALevel') + ['x-version-introduced' => '2.1.0'];
456-
$schemas[$itil_type]['properties']['ola_level_ttr'] = self::getDropdownTypeSchema(class: OlaLevel::class, field: 'olalevels_id_ttr', full_schema: 'OLALevel') + ['x-version-introduced' => '2.1.0'];
457454
$schemas[$itil_type]['properties']['sla_waiting_duration'] = [
458455
'x-version-introduced' => '2.1.0',
459456
'type' => Doc\Schema::TYPE_INTEGER,
460457
'readOnly' => true,
461458
'description' => 'Total SLA waiting duration in seconds',
462459
];
460+
/*
461+
* @FIXME There can be multiple OLAs now, how should we handle this?
462+
* - Should we provide the first element found in API v2.1.x?
463+
*
464+
$schemas[$itil_type]['properties']['ola_ttr'] = self::getDropdownTypeSchema(class: OLA::class, field: 'olas_id_ttr', full_schema: 'OLA') + ['x-version-introduced' => '2.1.0'];
465+
$schemas[$itil_type]['properties']['ola_tto'] = self::getDropdownTypeSchema(class: OLA::class, field: 'olas_id_tto', full_schema: 'OLA') + ['x-version-introduced' => '2.1.0'];
466+
$schemas[$itil_type]['properties']['ola_level_ttr'] = self::getDropdownTypeSchema(class: OlaLevel::class, field: 'olalevels_id_ttr', full_schema: 'OLALevel') + ['x-version-introduced' => '2.1.0'];
463467
$schemas[$itil_type]['properties']['ola_waiting_duration'] = [
464468
'x-version-introduced' => '2.1.0',
465469
'type' => Doc\Schema::TYPE_INTEGER,
@@ -492,6 +496,7 @@ public static function getRawKnownSchemas(): array
492496
'readOnly' => true,
493497
'x-field' => 'internal_time_to_own',
494498
];
499+
*/
495500
}
496501
if ($itil_type === Ticket::class || $itil_type === Change::class) {
497502
$schemas[$itil_type]['properties']['global_validation'] = [

0 commit comments

Comments
 (0)